Issue 1397703002: Revert of Provide RSA2048 as per RFC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1397703002: Revert of Provide RSA2048 as per RFC (Closed)

Created:
5 years, 2 months ago by torbjorng (webrtc)

Modified:
5 years, 2 months ago

Reviewers:
Henrik Grunell WebRTC, joachim, hbos, juberti

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Revert of Provide RSA2048 as per RFC (patchset #9 id:200001 of https://codereview.webrtc.org/1329493005/ ) Reason for revert: Breaks chrome. Original issue's description: > provide RSA2048 as per RFC > > BUG=webrtc:4972 > > Committed: https://crrev.com/0df3eb03c9a6a8299d7e18c8c314ca58c2f0681e > Cr-Commit-Position: refs/heads/master@{#10209} TBR=hbos@webrtc.org,juberti@google.com,jbauch@webrtc.org,henrikg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4972 Committed: https://crrev.com/335204c550e9570d356d0d6264475ac40c7f92f6 Cr-Commit-Position: refs/heads/master@{#10210}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -179 lines)			Patch
M	talk/app/webrtc/webrtcsession_unittest.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	webrtc/base/opensslidentity.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webrtc/base/opensslidentity.cc	View	6 chunks	+19 lines, -24 lines	0 comments	Download
M	webrtc/base/ssladapter_unittest.cc	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	webrtc/base/sslidentity.h	View	3 chunks	+8 lines, -93 lines	0 comments	Download
M	webrtc/base/sslidentity.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webrtc/base/sslstreamadapter_unittest.cc	View	8 chunks	+29 lines, -47 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397703002/1

5 years, 2 months ago (2015-10-08 09:30:04 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-08 09:30:28 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/335204c550e9570d356d0d6264475ac40c7f92f6
Cr-Commit-Position: refs/heads/master@{#10210}

Expand Messages | Collapse Messages