Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 1397653004: Add native-handle support for single VP8 streams. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman, perkj_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add native-handle support for single VP8 streams. Implements SupportsNativeHandle() in SimulcastEncoderAdapter which works when there's only a single encoder. BUG=webrtc:5060 R=stefan@webrtc.org Committed: https://crrev.com/65e15bafaaf18a5361a9831b17254810d5cb3111 Cr-Commit-Position: refs/heads/master@{#10291}

Patch Set 1 #

Total comments: 6

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -5 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 1 3 chunks +43 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
pbos-webrtc
PTAL, woo!
5 years, 2 months ago (2015-10-09 13:54:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397653004/1
5 years, 2 months ago (2015-10-09 13:54:49 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-09 14:36:49 UTC) #5
stefan-webrtc
lgtm https://codereview.webrtc.org/1397653004/diff/1/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc File webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc (right): https://codereview.webrtc.org/1397653004/diff/1/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc#newcode141 webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc:141: bool SupportsNativeHandle() const override { supports_native_handle https://codereview.webrtc.org/1397653004/diff/1/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc#newcode160 webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc:160: ...
5 years, 2 months ago (2015-10-13 15:07:52 UTC) #6
pbos-webrtc
feedback
5 years, 2 months ago (2015-10-15 16:42:47 UTC) #7
pbos-webrtc
https://codereview.webrtc.org/1397653004/diff/1/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc File webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc (right): https://codereview.webrtc.org/1397653004/diff/1/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc#newcode141 webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc:141: bool SupportsNativeHandle() const override { On 2015/10/13 15:07:51, stefan-webrtc ...
5 years, 2 months ago (2015-10-15 16:43:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397653004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397653004/20001
5 years, 2 months ago (2015-10-15 16:43:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 17:52:19 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 17:52:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65e15bafaaf18a5361a9831b17254810d5cb3111
Cr-Commit-Position: refs/heads/master@{#10291}

Powered by Google App Engine
This is Rietveld 408576698