Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1397363002: Revert of Adding support for simulcast and spatial layers into VideoQualityTest (Closed)

Created:
5 years, 2 months ago by sprang_webrtc
Modified:
5 years, 2 months ago
Reviewers:
ivica, pbos-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, andresp, perkj_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding support for simulcast and spatial layers into VideoQualityTest (patchset #10 id:180001 of https://codereview.webrtc.org/1353263005/ ) Reason for revert: Temporarily reverting as this causes some issues with perf tests. Especially tests with packet loss no longer works. Original issue's description: > Adding support for simulcast and spatial layers into VideoQualityTest > > The CL includes several changes: > - Adding flags describing the streams and spatial layers. > - Reorganizing the order of the flags, to make them easier to maintain. > - Adding a member .params_ to VideoQualityAnalyzer. > (instead of passing it to every member function manually) > - Updating VideoAnalyzer to support simulcast. > (select appropriate ssrc and fix timestamps which are sometimes increased by 1) > - VP9EncoderImpl already had code for automatic calculation of bitrate for each layer. > Changing to first read bitrates and resolution ratios from the flags, if specified. > If not specified, reverting to the old code are setting the values automatically. > - Changing the parameters in LayerFilteringTransport, replacing > xx_discard_thresholds with selected_xx, to make it easier to use for the end user. > > Committed: https://crrev.com/87f83a9a27d657731ccb54025bc04ccad0da136e > Cr-Commit-Position: refs/heads/master@{#10215} TBR=pbos@webrtc.org,mflodman@webrtc.org,ivica@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7a975f75e7fa7a9335411ef22b6687f78f7b297f Cr-Commit-Position: refs/heads/master@{#10252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -702 lines) Patch
M webrtc/common_types.h View 3 chunks +0 lines, -9 lines 0 comments Download
M webrtc/config.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 2 chunks +39 lines, -79 lines 0 comments Download
M webrtc/test/layer_filtering_transport.h View 2 chunks +6 lines, -8 lines 0 comments Download
M webrtc/test/layer_filtering_transport.cc View 3 chunks +16 lines, -22 lines 0 comments Download
M webrtc/video/full_stack.cc View 3 chunks +5 lines, -14 lines 0 comments Download
M webrtc/video/screenshare_loopback.cc View 6 chunks +47 lines, -110 lines 0 comments Download
M webrtc/video/video_loopback.cc View 5 chunks +40 lines, -99 lines 0 comments Download
M webrtc/video/video_quality_test.h View 3 chunks +10 lines, -37 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 14 chunks +123 lines, -312 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sprang_webrtc
Created Revert of Adding support for simulcast and spatial layers into VideoQualityTest
5 years, 2 months ago (2015-10-12 13:33:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397363002/1
5 years, 2 months ago (2015-10-12 13:33:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 13:33:27 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 13:33:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a975f75e7fa7a9335411ef22b6687f78f7b297f
Cr-Commit-Position: refs/heads/master@{#10252}

Powered by Google App Engine
This is Rietveld 408576698