Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: webrtc/audio_send_stream.h

Issue 1397123003: Add AudioSendStream to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: more tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/audio_send_stream.h
diff --git a/webrtc/audio_send_stream.h b/webrtc/audio_send_stream.h
index 2fb288f7abb67dd47ba445877573215798766ae8..03cf0f0478c387863d919742149dd042d56def17 100644
--- a/webrtc/audio_send_stream.h
+++ b/webrtc/audio_send_stream.h
@@ -54,7 +54,9 @@ class AudioSendStream : public SendStream {
// of Call.
int voe_channel_id = -1;
- rtc::scoped_ptr<AudioEncoder> encoder;
+ // Ownership of the encoder object is transferred to Call when the config is
+ // passed to Call::CreateAudioSendStream().
+ AudioEncoder* encoder = nullptr;
tommi 2015/10/14 13:21:18 I'm having a hard time understanding how the comme
the sun 2015/10/14 14:25:24 The config is *copied* into webrtc::internal::Audi
tommi 2015/10/14 14:49:28 I see... is it copied into the internal one then?
the sun 2015/10/15 12:56:06 Not clearcut what is the best approach here. I dec
int cng_payload_type = -1; // pt, or -1 to disable Comfort Noise Generator.
int red_payload_type = -1; // pt, or -1 to disable REDundant coding.
};

Powered by Google App Engine
This is Rietveld 408576698