Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2495)

Unified Diff: webrtc/audio_send_stream.h

Issue 1397123003: Add AudioSendStream to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/audio/webrtc_audio.gypi ('k') | webrtc/call/call.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/audio_send_stream.h
diff --git a/webrtc/audio_send_stream.h b/webrtc/audio_send_stream.h
index 2fb288f7abb67dd47ba445877573215798766ae8..b96a8ef988d27762fee545d2042e15bd8731c8d3 100644
--- a/webrtc/audio_send_stream.h
+++ b/webrtc/audio_send_stream.h
@@ -45,7 +45,8 @@ class AudioSendStream : public SendStream {
std::vector<RtpExtension> extensions;
} rtp;
- // Transport for outgoing packets.
+ // Transport for outgoing packets. The transport is expected to exist for
+ // the entire life of the AudioSendStream and is owned by the API client.
Transport* send_transport = nullptr;
// Underlying VoiceEngine handle, used to map AudioSendStream to lower-level
@@ -54,7 +55,10 @@ class AudioSendStream : public SendStream {
// of Call.
int voe_channel_id = -1;
- rtc::scoped_ptr<AudioEncoder> encoder;
+ // Ownership of the encoder object is transferred to Call when the config is
+ // passed to Call::CreateAudioSendStream().
+ // TODO(solenberg): Implement, once we configure codecs through the new API.
+ // rtc::scoped_ptr<AudioEncoder> encoder;
int cng_payload_type = -1; // pt, or -1 to disable Comfort Noise Generator.
int red_payload_type = -1; // pt, or -1 to disable REDundant coding.
};
« no previous file with comments | « webrtc/audio/webrtc_audio.gypi ('k') | webrtc/call/call.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698