Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1396873002: Allow to print Java stack traces in Android camera, renderer and media codec. (Closed)

Created:
5 years, 2 months ago by AlexG
Modified:
5 years, 2 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow to print Java stack traces in Android camera, renderer and media codec. R=wzh@webrtc.org Committed: https://crrev.com/f0159a742f39fe746053430a04b844ef2ead0770 Cr-Commit-Position: refs/heads/master@{#10227}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -20 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 1 2 chunks +12 lines, -1 line 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java View 1 7 chunks +32 lines, -2 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java View 3 chunks +13 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java View 1 3 chunks +13 lines, -2 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java View 1 1 chunk +13 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
AlexG
PTAL
5 years, 2 months ago (2015-10-08 18:53:49 UTC) #2
wzh
https://codereview.webrtc.org/1396873002/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java File talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java (right): https://codereview.webrtc.org/1396873002/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java#newcode580 talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java:580: StackTraceElement[] renderFrameStackTraces = renderFrameThread.getStackTrace(); i think the getStrackTrace() and ...
5 years, 2 months ago (2015-10-08 18:58:48 UTC) #3
AlexG
https://codereview.webrtc.org/1396873002/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java File talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java (right): https://codereview.webrtc.org/1396873002/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java#newcode580 talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java:580: StackTraceElement[] renderFrameStackTraces = renderFrameThread.getStackTrace(); On 2015/10/08 18:58:48, wzh wrote: ...
5 years, 2 months ago (2015-10-08 19:18:18 UTC) #4
wzh
lgtm
5 years, 2 months ago (2015-10-08 19:20:48 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396873002/20001
5 years, 2 months ago (2015-10-08 19:22:46 UTC) #7
AlexG
Committed patchset #2 (id:20001) manually as f0159a742f39fe746053430a04b844ef2ead0770 (presubmit successful).
5 years, 2 months ago (2015-10-08 19:59:37 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 19:59:41 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f0159a742f39fe746053430a04b844ef2ead0770
Cr-Commit-Position: refs/heads/master@{#10227}

Powered by Google App Engine
This is Rietveld 408576698