Get rid of deprecated HttpClient fail_redirect accessors.

Get rid of deprecated HttpClient fail_redirect accessors.

This patch removes set_fail_redirect()/fail_redirect() method accessors
from HttpClient class and converts their usage to
set_redirection_action/redirection_action where appropriate.

BUG=None
R=pthatcher@webrtc.org

Committed: https://crrev.com/6ca1ac42836fb005f67514b8deb7a1dc8d59247b
Cr-Commit-Position: refs/heads/master@{#10304}

[tfarina, 2015-10-14 16:33:06]

Ping!

[tfarina, 2015-10-15 20:21:59]

tfarina@chromium.org changed reviewers:
+ juberti@webrtc.org

[tfarina, 2015-10-15 20:21:59]

juberti, could you review this to me?

[juberti2, 2015-10-15 20:30:58]

juberti@chromium.org changed reviewers:
+ juberti@chromium.org

[juberti2, 2015-10-15 20:30:59]

https://codereview.chromium.org/1396683005/diff/1/webrtc/base/httprequest.cc
File webrtc/base/httprequest.cc (right):

https://codereview.chromium.org/1396683005/diff/1/webrtc/base/httprequest.cc#...
webrtc/base/httprequest.cc:87:
client_.set_redirect_action(HttpClient::REDIRECT_NEVER);
while this seems like it keeps the literal meaning of the previous code, I think
the semantics are incorrect. I think the default should be REDIRECT_ALWAYS.

[tfarina, 2015-10-15 22:26:42]

https://codereview.chromium.org/1396683005/diff/1/webrtc/base/httprequest.cc
File webrtc/base/httprequest.cc (right):

https://codereview.chromium.org/1396683005/diff/1/webrtc/base/httprequest.cc#...
webrtc/base/httprequest.cc:87:
client_.set_redirect_action(HttpClient::REDIRECT_NEVER);
On 2015/10/15 20:30:59, juberti2 wrote:
> while this seems like it keeps the literal meaning of the previous code, I
think
> the semantics are incorrect. I think the default should be REDIRECT_ALWAYS.

Done.

[tfarina, 2015-10-16 13:32:08]

Ping juberti?

[juberti2, 2015-10-16 17:01:41]

lgtm

[juberti2, 2015-10-16 17:02:08]

On 2015/10/16 17:01:41, juberti2 wrote:
> lgtm

lgtm

[tfarina, 2015-10-16 17:44:11]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-10-16 17:44:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1396683005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1396683005/20001

[commit-bot: I haz the power, 2015-10-16 17:44:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 17:44:26]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tommi, 2015-10-16 18:00:18]

tommi@webrtc.org changed reviewers:
+ tommi@webrtc.org

[tommi, 2015-10-16 18:00:18]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2015-10-16 18:00:18]

lgtm

[commit-bot: I haz the power, 2015-10-16 18:00:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1396683005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1396683005/20001

[commit-bot: I haz the power, 2015-10-16 18:01:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-16 18:01:51]

Patchset 2 (id:??) landed as
https://crrev.com/6ca1ac42836fb005f67514b8deb7a1dc8d59247b
Cr-Commit-Position: refs/heads/master@{#10304}