Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1396653002: Use WebRTC logging in MediaCodec JNI code. (Closed)

Created:
5 years, 2 months ago by AlexG
Modified:
5 years, 2 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use WebRTC logging in MediaCodec JNI code. Also enable HW encoder scaling in AppRTCDemo. R=wzh@webrtc.org Committed: https://crrev.com/fddf6e526c8a49e8d67810881c5bed44e2573474 Cr-Commit-Position: refs/heads/master@{#10205}

Patch Set 1 #

Patch Set 2 : i #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -86 lines) Patch
M talk/app/webrtc/java/jni/androidmediacodeccommon.h View 3 chunks +5 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/jni/androidmediadecoder_jni.cc View 1 30 chunks +54 lines, -51 lines 0 comments Download
M talk/app/webrtc/java/jni/androidmediaencoder_jni.cc View 15 chunks +32 lines, -28 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
AlexG
PTAL
5 years, 2 months ago (2015-10-07 23:27:49 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396653002/20001
5 years, 2 months ago (2015-10-07 23:28:43 UTC) #4
wzh
lgtm
5 years, 2 months ago (2015-10-07 23:30:43 UTC) #5
AlexG
Committed patchset #2 (id:20001) manually as fddf6e526c8a49e8d67810881c5bed44e2573474 (presubmit successful).
5 years, 2 months ago (2015-10-07 23:51:25 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 23:51:30 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fddf6e526c8a49e8d67810881c5bed44e2573474
Cr-Commit-Position: refs/heads/master@{#10205}

Powered by Google App Engine
This is Rietveld 408576698