Issue 1396573003: Android SurfaceViewRenderer: Only clear image in release() if initialized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1396573003: Android SurfaceViewRenderer: Only clear image in release() if initialized (Closed)

Created:
5 years, 2 months ago by magjed_webrtc

Modified:
5 years, 2 months ago

Reviewers:
hbos

CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Android SurfaceViewRenderer: Only clear image in release() if initialized This CL is a small bug fix for "Android SurfaceViewRenderer: Allow to re-init after release() has been called" https://codereview.webrtc.org/1389203003/. It is only possible to clear the last image in release() if init() has been called beforehand. TBR=hbos BUG=webrtc:4742 Committed: https://chromium.googlesource.com/external/webrtc/+/bf2004bc3735c7cd12e345b469c3994b72629047

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 3 (1 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/bf2004bc3735c7cd12e345b469c3994b72629047 Cr-Commit-Position: refs/heads/master@{#10223}

5 years, 2 months ago (2015-10-08 16:58:38 UTC) #2

magjed_webrtc

5 years, 2 months ago (2015-10-08 16:58:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bf2004bc3735c7cd12e345b469c3994b72629047 (presubmit successful).