Android: Replace EGL14 with EGL10

Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14 (API lvl 17) with EGL10 (API lvl 1). The main purpose is to lower API lvl requirement for SurfaceViewRenderer from API lvl 17 to API lvl 15. Also, camera texture capture will work on API lvl < 17 (and texture encode/decode in MediaCodec, but we don't use MediaCodec below API lvl 18?).

GLSurfaceView/VideoRendererGui is already using EGL10.

EGL 1.1 - 1.4 added new functionality, but won't affect performance. We don't need the functionality, so there should be no reason to not use EGL 1.0.

I have profiled AppRTCDemo with Qualcomm Trepn Profiler on a Nexus 5 and Nexus 6 and couldn't see any difference.

Specifically, this CL:
 * Update EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.

Committed: https://crrev.com/8c425aa8f66fc2f06df402a0f2163cb53373856f
Cr-Commit-Position: refs/heads/master@{#10378}

[magjed_webrtc, 2015-10-20 18:43:54]

Description was changed from

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels. EGL14 was added in
API lvl 17 (JELLY_BEAN_MR1). EGL10 was added in API lvl 1.
==========

to

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then we can support camera texture capture
and texture encode/decode in MediaCodec on all API lvls.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing include
order in some cases).
 *  Update VideoCapturerAndroid to always support texture capture.
==========

[magjed_webrtc, 2015-10-20 18:44:05]

Description was changed from

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then we can support camera texture capture
and texture encode/decode in MediaCodec on all API lvls.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing include
order in some cases).
 *  Update VideoCapturerAndroid to always support texture capture.
==========

to

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then we can support camera texture capture
and texture encode/decode in MediaCodec on all API lvls.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing include
order in some cases).
 *  Update VideoCapturerAndroid to always support texture capture.
==========

[magjed_webrtc, 2015-10-20 18:44:16]

Description was changed from

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then we can support camera texture capture
and texture encode/decode in MediaCodec on all API lvls.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing include
order in some cases).
 *  Update VideoCapturerAndroid to always support texture capture.
==========

to

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then we can support camera texture capture
and texture encode/decode in MediaCodec on all API lvls.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing include
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

[magjed_webrtc, 2015-10-20 18:45:29]

Description was changed from

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then we can support camera texture capture
and texture encode/decode in MediaCodec on all API lvls.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing include
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

to

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing include
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

[magjed_webrtc, 2015-10-20 18:46:20]

Description was changed from

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing include
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

to

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

[magjed_webrtc, 2015-10-20 18:57:31]

magjed@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[magjed_webrtc, 2015-10-20 18:59:33]

magjed@webrtc.org changed reviewers:
+ perkj@webrtc.org

[magjed_webrtc, 2015-10-20 22:36:45]

Patchset #2 (id:20001) has been deleted

[magjed_webrtc, 2015-10-20 22:50:40]

Alex - Can you help me manually test this CL?

[perkj_webrtc, 2015-10-21 03:30:22]

On 2015/10/20 22:50:40, magjed_webrtc wrote:
> Alex - Can you help me manually test this CL?

Magnus, have you seen the failing bots?  Looks like a problem with this cl?

Have you tried to compare performance with and without this patch?

[magjed_webrtc, 2015-10-21 03:46:58]

On 2015/10/21 03:30:22, perkj1 wrote:
> On 2015/10/20 22:50:40, magjed_webrtc wrote:
> > Alex - Can you help me manually test this CL?
> 
> Magnus, have you seen the failing bots?  Looks like a problem with this cl?
> 
> Have you tried to compare performance with and without this patch?

I think those bots are broken at the moment - they are failing for everyone the
last 6 runs.

I profiled AppRTCDemo on a Nexus 5 and couldn't see any difference. I can try on
a Nexus 6 (yours) tomorrow.

[magjed_webrtc, 2015-10-21 15:17:13]

Description was changed from

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

to

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.

I have profiled AppRTCDemo with Qualcomm Trepn Profiler on a Nexus 5 and
couldn't see any difference.
==========

[magjed_webrtc, 2015-10-21 15:19:03]

Description was changed from

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.

I have profiled AppRTCDemo with Qualcomm Trepn Profiler on a Nexus 5 and
couldn't see any difference.
==========

to

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

GLSurfaceView/VideoRendererGui is already using EGL10.

I have profiled AppRTCDemo with Qualcomm Trepn Profiler on a Nexus 5 and
couldn't see any difference.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

[magjed_webrtc, 2015-10-21 15:23:24]

Description was changed from

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

GLSurfaceView/VideoRendererGui is already using EGL10.

I have profiled AppRTCDemo with Qualcomm Trepn Profiler on a Nexus 5 and
couldn't see any difference.

Specifically, this CL:
 * Updates EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

to

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

GLSurfaceView/VideoRendererGui is already using EGL10.

I have profiled AppRTCDemo with Qualcomm Trepn Profiler on a Nexus 5 and
couldn't see any difference.

Specifically, this CL:
 * Update EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

[perkj_webrtc, 2015-10-21 15:26:57]

lgtm if the below is addressed.

https://codereview.webrtc.org/1396013004/diff/40001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/EglBase.java (right):

https://codereview.webrtc.org/1396013004/diff/40001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:46: private static final
int EGL_OPENGL_ES2_BIT = 4;
Document what this is and and why it is hardcoded to 4.

https://codereview.webrtc.org/1396013004/diff/40001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:47: private static final
int EGL_CONTEXT_CLIENT_VERSION = 0x3098;
Dito

[magjed_webrtc, 2015-10-21 21:35:28]

Description was changed from

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

GLSurfaceView/VideoRendererGui is already using EGL10.

I have profiled AppRTCDemo with Qualcomm Trepn Profiler on a Nexus 5 and
couldn't see any difference.

Specifically, this CL:
 * Update EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

to

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

GLSurfaceView/VideoRendererGui is already using EGL10.

I have profiled AppRTCDemo with Qualcomm Trepn Profiler on a Nexus 5 and Nexus 6
and couldn't see any difference.

Specifically, this CL:
 * Update EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

[magjed_webrtc, 2015-10-21 21:54:35]

https://codereview.webrtc.org/1396013004/diff/40001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/EglBase.java (right):

https://codereview.webrtc.org/1396013004/diff/40001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:46: private static final
int EGL_OPENGL_ES2_BIT = 4;
On 2015/10/21 15:26:57, perkj1 wrote:
> Document what this is and and why it is hardcoded to 4.

Done.

https://codereview.webrtc.org/1396013004/diff/40001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:47: private static final
int EGL_CONTEXT_CLIENT_VERSION = 0x3098;
On 2015/10/21 15:26:57, perkj1 wrote:
> Dito

Done.

[AlexG, 2015-10-22 00:15:41]

May be it will be better to use same approach as MediaCodec and VideorendererGui
was using before - if API level is below 17 than EGLContext will be null and
texture decoding and rendering will be disabled? MediaCodec anyway is not useful
below KK due to missing functionality (now key frame request API). And apart
from HW encoder/decoder is there any other reason to use texture
capturing/rendering?

[magjed_webrtc, 2015-10-22 16:14:31]

Description was changed from

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

GLSurfaceView/VideoRendererGui is already using EGL10.

I have profiled AppRTCDemo with Qualcomm Trepn Profiler on a Nexus 5 and Nexus 6
and couldn't see any difference.

Specifically, this CL:
 * Update EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

to

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

GLSurfaceView/VideoRendererGui is already using EGL10.

EGL 1.1 - 1.4 added new functionality, but won't affect performance. We don't
need the functionality, so there should be no reason to not use EGL 1.0.

I have profiled AppRTCDemo with Qualcomm Trepn Profiler on a Nexus 5 and Nexus 6
and couldn't see any difference.

Specifically, this CL:
 * Update EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

[magjed_webrtc, 2015-10-22 16:51:48]

Description was changed from

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). Then camera texture capture and texture
encode/decode in MediaCodec is supported on all API lvls.

GLSurfaceView/VideoRendererGui is already using EGL10.

EGL 1.1 - 1.4 added new functionality, but won't affect performance. We don't
need the functionality, so there should be no reason to not use EGL 1.0.

I have profiled AppRTCDemo with Qualcomm Trepn Profiler on a Nexus 5 and Nexus 6
and couldn't see any difference.

Specifically, this CL:
 * Update EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

to

==========
Android: Replace EGL14 with EGL10

The purpose with this change is to support older API levels by replacing EGL14
(API lvl 17) with EGL10 (API lvl 1). The main purpose is to lower API lvl
requirement for SurfaceViewRenderer from API lvl 17 to API lvl 15. Also, camera
texture capture will work on API lvl < 17 (and texture encode/decode in
MediaCodec, but we don't use MediaCodec below API lvl 18?).

GLSurfaceView/VideoRendererGui is already using EGL10.

EGL 1.1 - 1.4 added new functionality, but won't affect performance. We don't
need the functionality, so there should be no reason to not use EGL 1.0.

I have profiled AppRTCDemo with Qualcomm Trepn Profiler on a Nexus 5 and Nexus 6
and couldn't see any difference.

Specifically, this CL:
 * Update EglBase to use EGL10 instead of EGL14.
 * Update imports from EGL14 to EGL10 in a lot of files (plus changing import
order in some cases).
 * Update VideoCapturerAndroid to always support texture capture.
==========

[magjed_webrtc, 2015-10-22 18:14:38]

Actually, the main purpose with this CL is to lower the API lvl requirement for
SurfaceViewRenderer from API lvl 17 to API lvl 15. I have updated the CL
description. It shouldn’t affect MediaCodec if we don’t use MediaCodec below KK.

[AlexG, 2015-10-22 21:22:51]

lgtm

[magjed_webrtc, 2015-10-22 23:06:47]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2015-10-22 23:06:47]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1396013004/#ps60001 (title:
"Add comments for hardcoded EGL constants")

[commit-bot: I haz the power, 2015-10-22 23:06:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1396013004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1396013004/60001

[commit-bot: I haz the power, 2015-10-22 23:52:43]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-10-22 23:52:56]

Patchset 3 (id:??) landed as
https://crrev.com/8c425aa8f66fc2f06df402a0f2163cb53373856f
Cr-Commit-Position: refs/heads/master@{#10378}