Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1395673003: Native changes for VideoCapturerAndroid surface texture support (Closed)

Created:
5 years, 2 months ago by perkj_webrtc
Modified:
5 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Native changes for VideoCapturerAndroid surface texture support These are the necessary changes in C++ related to the video capturer necessary to capture to a surface texture. It does not handle scaling / cropping yet though. BUG=webrtc:4993 R=magjed@webrtc.org Committed: https://crrev.com/ac30642461c4f94916741106e3ba3f3b7b670a47 Cr-Commit-Position: refs/heads/master@{#10218}

Patch Set 1 #

Patch Set 2 : Style fixes #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -24 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 4 chunks +4 lines, -8 lines 0 comments Download
M talk/app/webrtc/androidvideocapturer.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/jni/androidvideocapturer_jni.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M talk/app/webrtc/java/jni/androidvideocapturer_jni.cc View 1 2 5 chunks +64 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perkj_webrtc
Please?
5 years, 2 months ago (2015-10-08 12:53:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395673003/20001
5 years, 2 months ago (2015-10-08 12:54:08 UTC) #4
magjed_webrtc
lgtm https://codereview.webrtc.org/1395673003/diff/20001/talk/app/webrtc/java/jni/androidvideocapturer_jni.cc File talk/app/webrtc/java/jni/androidvideocapturer_jni.cc (right): https://codereview.webrtc.org/1395673003/diff/20001/talk/app/webrtc/java/jni/androidvideocapturer_jni.cc#newcode187 talk/app/webrtc/java/jni/androidvideocapturer_jni.cc:187: int64_t timestamp) { Can you add unit as ...
5 years, 2 months ago (2015-10-08 13:15:37 UTC) #5
perkj_webrtc
Committed patchset #3 (id:40001) manually as ac30642461c4f94916741106e3ba3f3b7b670a47 (presubmit successful).
5 years, 2 months ago (2015-10-08 13:32:50 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 13:32:53 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ac30642461c4f94916741106e3ba3f3b7b670a47
Cr-Commit-Position: refs/heads/master@{#10218}

Powered by Google App Engine
This is Rietveld 408576698