Chromium Code Reviews

Issue 1395543004: Android SurfaceTextureHelper: Replace API 21 with API 11 version of setOnFrameAvailableListener() (Closed)

Created:
5 years, 2 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
AlexG, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, phoglund
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android SurfaceTextureHelper: Replace API 21 with API 11 version of setOnFrameAvailableListener() BUG=b/24809429 R=glaznev@webrtc.org, perkj@webrtc.org Committed: https://crrev.com/747c1bccd961a88285d6bfeebcec0cb25f719dfb Cr-Commit-Position: refs/heads/master@{#10247}

Patch Set 1 #

Patch Set 2 : Construct the SurfaceTexture on the handler thread instead #

Unified diffs Side-by-side diffs Stats (+62 lines, -47 lines)
M talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java View 1 chunk +1 line, -1 line 0 comments
M talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java View 6 chunks +7 lines, -5 lines 0 comments
M talk/app/webrtc/java/android/org/webrtc/SurfaceTextureHelper.java View 9 chunks +40 lines, -25 lines 0 comments
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 1 chunk +2 lines, -3 lines 0 comments
M talk/app/webrtc/java/jni/surfacetexturehelper_jni.cc View 1 chunk +12 lines, -13 lines 0 comments

Messages

Total messages: 10 (4 generated)
magjed_webrtc
Please take a look.
5 years, 2 months ago (2015-10-09 22:11:19 UTC) #2
AlexG
lgtm
5 years, 2 months ago (2015-10-09 22:56:33 UTC) #3
perkj_webrtc
On 2015/10/09 22:56:33, AlexG wrote: > lgtm lgtm
5 years, 2 months ago (2015-10-11 14:28:16 UTC) #4
magjed_webrtc
Committed patchset #2 (id:80001) manually as 747c1bccd961a88285d6bfeebcec0cb25f719dfb (presubmit successful).
5 years, 2 months ago (2015-10-12 07:28:02 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/747c1bccd961a88285d6bfeebcec0cb25f719dfb Cr-Commit-Position: refs/heads/master@{#10247}
5 years, 2 months ago (2015-10-12 07:28:05 UTC) #9
AlexG
5 years, 2 months ago (2015-10-12 19:14:30 UTC) #10
Message was sent while issue was closed.
+Patrik
Please revert/redo this patch - you are using Looper.isCurrentThread which is
added in API v.23 only.

Powered by Google App Engine