Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1395523002: Added parsing of either space or colon for sctp-port. (Closed)

Created:
5 years, 2 months ago by lally1
Modified:
5 years, 2 months ago
Reviewers:
pthatcher2, pthatcher1
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added parsing of either space or colon for sctp-port. BUG=https://code.google.com/p/webrtc/issues/detail?id=5039 Committed: https://crrev.com/69f576010edae80bc83fbf51fa06c3ee611125e8 Cr-Commit-Position: refs/heads/master@{#10225}

Patch Set 1 #

Patch Set 2 : Took out a bad check. #

Patch Set 3 : Added requested TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M talk/app/webrtc/webrtcsdp.cc View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
M talk/app/webrtc/webrtcsdp_unittest.cc View 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
lally1
ref: a=sctp-port[: ]NUMBER Ok, try a colon delimiter first, and then spaces if that didn't ...
5 years, 2 months ago (2015-10-07 14:25:29 UTC) #2
pthatcher1
lgtm Can you also add a TODO in the proper place to generate the SDP ...
5 years, 2 months ago (2015-10-08 05:05:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395523002/40001
5 years, 2 months ago (2015-10-08 15:38:25 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-08 17:15:08 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 17:15:31 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/69f576010edae80bc83fbf51fa06c3ee611125e8
Cr-Commit-Position: refs/heads/master@{#10225}

Powered by Google App Engine
This is Rietveld 408576698