Make the high frequency correction range depend on the target angle

Make the high frequency correction range depend on the target angle

Depends on this CL: https://codereview.webrtc.org/1388033002/

Committed: https://crrev.com/1897f77806baad82d321efb6c4c2f27f8c9458b3
Cr-Commit-Position: refs/heads/master@{#10331}

[aluebs-webrtc, 2015-10-08 00:10:28]

aluebs@webrtc.org changed reviewers:
+ andrew@webrtc.org

[Andrew MacDonald, 2015-10-13 22:09:21]

Code looks good; just a question about the performance.

https://codereview.webrtc.org/1395453004/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc (right):

https://codereview.webrtc.org/1395453004/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc:262:
sample_rate_hz_ / 2.f);
This results in a fairly similar range as before when mic_spacing_ = 0.05. Have
you tested this somewhat less heuristic approach vs our current fully heuristic
approach across a few different devices?

[aluebs-webrtc, 2015-10-17 01:01:22]

https://codereview.webrtc.org/1395453004/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc (right):

https://codereview.webrtc.org/1395453004/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc:262:
sample_rate_hz_ / 2.f);
On 2015/10/13 22:09:21, Andrew MacDonald wrote:
> This results in a fairly similar range as before when mic_spacing_ = 0.05.
Have
> you tested this somewhat less heuristic approach vs our current fully
heuristic
> approach across a few different devices?

Yes, I tested it on all supported Chromebooks.
This change was originally introduced because of the smaller spacing of some
other devices (4mics-2cm).

[Andrew MacDonald, 2015-10-17 04:02:41]

lgtm

[aluebs-webrtc, 2015-10-20 01:33:51]

Patchset #4 (id:60001) has been deleted

[aluebs-webrtc, 2015-10-20 01:33:58]

The CQ bit was checked by aluebs@webrtc.org

[commit-bot: I haz the power, 2015-10-20 01:34:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395453004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395453004/40001

[commit-bot: I haz the power, 2015-10-20 02:19:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 02:19:52]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: [Errno 104] Connection reset by peer

[commit-bot: I haz the power, 2015-10-20 02:19:55]

The CQ bit was unchecked by commit-bot@chromium.org

[aluebs-webrtc, 2015-10-20 02:45:31]

The CQ bit was checked by aluebs@webrtc.org

[commit-bot: I haz the power, 2015-10-20 02:45:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395453004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395453004/40001

[commit-bot: I haz the power, 2015-10-20 02:49:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-20 02:49:44]

Patchset 3 (id:??) landed as
https://crrev.com/1897f77806baad82d321efb6c4c2f27f8c9458b3
Cr-Commit-Position: refs/heads/master@{#10331}