Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1394823002: Remove internal encoders from VCMCodecDatabase. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove internal encoders from VCMCodecDatabase. Encoders need to be externally provided. To use software encoders they need to be created and registered from the outside. BUG=webrtc:1695 R=stefan@webrtc.org Committed: https://crrev.com/ab73d13c4b632d8fa8cf6913e503d462567a40e3 Cr-Commit-Position: refs/heads/master@{#10283}

Patch Set 1 #

Total comments: 1

Patch Set 2 : scoped_ptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -65 lines) Patch
M webrtc/modules/video_coding/main/source/codec_database.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/main/source/codec_database.cc View 1 6 chunks +13 lines, -60 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_sender_unittest.cc View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pbos-webrtc
PTAL
5 years, 2 months ago (2015-10-08 11:48:27 UTC) #1
stefan-webrtc
lgtm https://codereview.webrtc.org/1394823002/diff/1/webrtc/modules/video_coding/main/source/codec_database.cc File webrtc/modules/video_coding/main/source/codec_database.cc (right): https://codereview.webrtc.org/1394823002/diff/1/webrtc/modules/video_coding/main/source/codec_database.cc#newcode647 webrtc/modules/video_coding/main/source/codec_database.cc:647: delete ptr_encoder_; Could you make this scoped?
5 years, 2 months ago (2015-10-15 07:43:36 UTC) #2
pbos-webrtc
scoped_ptr
5 years, 2 months ago (2015-10-15 09:58:38 UTC) #3
pbos-webrtc
Committed patchset #2 (id:20001) manually as ab73d13c4b632d8fa8cf6913e503d462567a40e3 (presubmit successful).
5 years, 2 months ago (2015-10-15 10:01:55 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 10:01:59 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab73d13c4b632d8fa8cf6913e503d462567a40e3
Cr-Commit-Position: refs/heads/master@{#10283}

Powered by Google App Engine
This is Rietveld 408576698