Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1394463002: Fixing perf regression caused by refactoring full stack tests (Closed)

Created:
5 years, 2 months ago by ivica
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing perf regression caused by refactoring full stack tests Calling CreateCapturer after CreateStreams. The wrong order of calling those methods seems to have caused perf regressions. Testing has been done here: https://codereview.webrtc.org/1371113004/ BUG=chromium:534220 Committed: https://crrev.com/c1cc854d546f68392242370f9dd13bdb8db1398b Cr-Commit-Position: refs/heads/master@{#10212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M webrtc/video/video_quality_test.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394463002/1
5 years, 2 months ago (2015-10-07 09:57:35 UTC) #2
ivica
5 years, 2 months ago (2015-10-07 10:01:06 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-07 11:05:32 UTC) #6
sprang_webrtc
rs lgtm +pbos@, ptal. Any idea why this would change the behavior?
5 years, 2 months ago (2015-10-08 09:39:28 UTC) #8
pbos-webrtc
Looking at it the timer is started in FrameGeneratorCapturer::Init() so this is slightly different timing ...
5 years, 2 months ago (2015-10-08 09:47:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394463002/1
5 years, 2 months ago (2015-10-08 09:59:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 10:44:12 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 10:44:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1cc854d546f68392242370f9dd13bdb8db1398b
Cr-Commit-Position: refs/heads/master@{#10212}

Powered by Google App Engine
This is Rietveld 408576698