webrtc/video_engine/vie_channel.cc - Issue 1394243006: Move ownership of send ViEChannels and ViEEncoder to VideoSendStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video_engine/vie_channel.cc

Issue 1394243006: Move ownership of send ViEChannels and ViEEncoder to VideoSendStream. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Based on pbos, stefan feedback. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/video_engine/vie_channel.cc

diff --git a/webrtc/video_engine/vie_channel.cc b/webrtc/video_engine/vie_channel.cc

index 84a86f873513a7870ee07cbfefa8abb398011c07..e2c92c6120989ff7c4fb05b60f1b420fa943fdad 100644

--- a/webrtc/video_engine/vie_channel.cc

+++ b/webrtc/video_engine/vie_channel.cc

@@ -725,9 +725,8 @@ int32_t ViEChannel::GetLocalSSRC(uint8_t idx, unsigned int* ssrc) {

return 0;

}

-int32_t ViEChannel::GetRemoteSSRC(uint32_t* ssrc) {

+void ViEChannel::GetRemoteSSRC(uint32_t* ssrc) {

pbos-webrtc 2015/10/15 14:41:44 return uint32_t then?

mflodman 2015/10/15 14:47:42 Hmm, I kind of see your point...

*ssrc = vie_receiver_.GetRemoteSsrc();

- return 0;

}

int ViEChannel::SetRtxSendPayloadType(int payload_type,

« no previous file with comments | « webrtc/video_engine/vie_channel.h ('k') | webrtc/video_engine/vie_channel_group.h » ('j') | no next file with comments »