Provide RSA2048 as per RFC

Provide RSA2048 as per RFC

Original CL here:
https://codereview.webrtc.org/1329493005

That CL is in patch set #1 of this CL.
This CL resolves a method collision in Chrome.

BUG=webrtc:4972
Committed: https://crrev.com/4e572470a3f181a043f9f9b98cc0153b7195b9f5
Cr-Commit-Position: refs/heads/master@{#10222}

[torbjorng (webrtc), 2015-10-08 11:58:13]

The CQ bit was checked by torbjorng@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-08 11:58:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1394223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1394223002/20001

[commit-bot: I haz the power, 2015-10-08 12:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-08 12:44:32]

Dry run: This issue passed the CQ dry run.

[torbjorng (webrtc), 2015-10-08 13:28:36]

torbjorng@webrtc.org changed reviewers:
+ hbos@webrtc.org, henrikg@webrtc.org

[torbjorng (webrtc), 2015-10-08 13:32:48]

PTAL henrikg, hbos.

This is the same as https://codereview.webrtc.org/1329493005 except that
KeyParams' methods are now all in sslidentiy.cc instead of in its .h file.

I reverted that CL due to problems with including checks.h in a .h file, which
caused a collision with chromium's logging.h. Removing methods from the .h file
is probably also a good idea.

[Henrik Grunell WebRTC, 2015-10-08 13:45:32]

LGTM assuming nit is fixed. I just reviewed the move, not the code since it was
done in previous CL.

https://codereview.webrtc.org/1394223002/diff/20001/webrtc/base/sslidentity.cc
File webrtc/base/sslidentity.cc (right):

https://codereview.webrtc.org/1394223002/diff/20001/webrtc/base/sslidentity.c...
webrtc/base/sslidentity.cc:50: KeyParams KeyParams::RSA(int mod_size, int
pub_exp) {
Nit: Add
// static
above the static functions.

[hbos, 2015-10-08 13:46:00]

lgtm with one comment

https://codereview.webrtc.org/1394223002/diff/20001/webrtc/base/sslidentity.h
File webrtc/base/sslidentity.h (right):

https://codereview.webrtc.org/1394223002/diff/20001/webrtc/base/sslidentity.h...
webrtc/base/sslidentity.h:121: static const int kRsaMaxModSize = 8192;
Make these extern and place values in .cc file (just like kPemTypeCertificate
and the like at the bottom of this file)

[torbjorng (webrtc), 2015-10-08 14:01:46]

Thanks for feedback!

https://codereview.webrtc.org/1394223002/diff/20001/webrtc/base/sslidentity.cc
File webrtc/base/sslidentity.cc (right):

https://codereview.webrtc.org/1394223002/diff/20001/webrtc/base/sslidentity.c...
webrtc/base/sslidentity.cc:50: KeyParams KeyParams::RSA(int mod_size, int
pub_exp) {
On 2015/10/08 13:45:32, Henrik Grunell (webrtc) wrote:
> Nit: Add
> // static
> above the static functions.

Done.

https://codereview.webrtc.org/1394223002/diff/20001/webrtc/base/sslidentity.h
File webrtc/base/sslidentity.h (right):

https://codereview.webrtc.org/1394223002/diff/20001/webrtc/base/sslidentity.h...
webrtc/base/sslidentity.h:121: static const int kRsaMaxModSize = 8192;
On 2015/10/08 13:46:00, hbos wrote:
> Make these extern and place values in .cc file (just like kPemTypeCertificate
> and the like at the bottom of this file)

I would have agreed if these had been e.g., C string constants where any value
would be put the the binary. Here we have integer constants which will be
compiled into the actual code with the current form.

[torbjorng (webrtc), 2015-10-08 14:01:56]

The CQ bit was checked by torbjorng@webrtc.org

[commit-bot: I haz the power, 2015-10-08 14:02:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1394223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1394223002/20001

[commit-bot: I haz the power, 2015-10-08 14:03:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-08 14:03:47]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1155)

[torbjorng (webrtc), 2015-10-08 14:06:21]

torbjorng@webrtc.org changed reviewers:
+ perkj@webrtc.org

[torbjorng (webrtc), 2015-10-08 14:08:55]

PTAL perkj.

This is https://codereview.webrtc.org/1329493005 redone, with things moved from
a .cc to a .h file. I need stamping for
talk/app/webrtc/webrtcsession_unittest.cc which did not change.

[torbjorng (webrtc), 2015-10-08 14:20:13]

The CQ bit was checked by torbjorng@webrtc.org

[torbjorng (webrtc), 2015-10-08 14:20:13]

The patchset sent to the CQ was uploaded after l-g-t-m from henrikg@webrtc.org,
hbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1394223002/#ps60001 (title:
" ")

[commit-bot: I haz the power, 2015-10-08 14:20:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1394223002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1394223002/60001

[torbjorng (webrtc), 2015-10-08 14:23:29]

torbjorng@webrtc.org changed reviewers:
- perkj@webrtc.org

[commit-bot: I haz the power, 2015-10-08 16:42:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-08 16:43:12]

Patchset 4 (id:??) landed as
https://crrev.com/4e572470a3f181a043f9f9b98cc0153b7195b9f5
Cr-Commit-Position: refs/heads/master@{#10222}