Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1394103005: Revert "Android MediaCodecVideoDecoder: Manage lifetime of texture frames" (Closed)

Created:
5 years, 2 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
AlexG, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of "Android MediaCodecVideoDecoder: Manage lifetime of texture frames" https://codereview.webrtc.org/1378033003/ The code that depends on the reverted CL is disabled but not removed. NativeHandleImpl is reverted to the previous implementation, and the new implementation is renamed to NativeTextureHandleImpl. Texture capture can not be used anymore, because it will crash in peerconnection_jni.cc. Reason for revert: Increased HW decoder latency and crashes related to that. Also suspected cause of video tearing. Original issue's description: > This CL should be the last one in a series to finally > unblock camera texture capture. > > The SurfaceTexture.updateTexImage() calls are moved from > the video renderers into MediaCodecVideoDecoder, and the > destructor of the texture frames will signal > MediaCodecVideoDecoder that the frame has returned. This > CL also removes the SurfaceTexture from the native handle > and only exposes the texture matrix instead, because only > the video source should access the SurfaceTexture. > > BUG=webrtc:4993 > R=glaznev@webrtc.org, perkj@webrtc.org > > Committed: https://crrev.com/91b348c7029d843e06868ed12b728a809c53176c > Cr-Commit-Position: refs/heads/master@{#10203} TBR=glaznev BUG=webrtc:4993 Committed: https://crrev.com/543b6ca30a43eeb069c699291460ce6bacc7959d Cr-Commit-Position: refs/heads/master@{#10288}

Patch Set 1 : Pure revert of "Android MediaCodecVideoDecoder: Manage lifetime of texture frames" #

Patch Set 2 : Fork NativeHandleImpl and disable texture capture, plus some revert rebase nits #

Total comments: 1

Patch Set 3 : Uncomment android capture code and add bug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -170 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 1 2 4 chunks +8 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java View 1 chunk +16 lines, -1 line 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java View 1 2 chunks +18 lines, -3 lines 0 comments Download
M talk/app/webrtc/java/jni/androidmediadecoder_jni.cc View 16 chunks +42 lines, -28 lines 0 comments Download
M talk/app/webrtc/java/jni/androidvideocapturer_jni.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/java/jni/androidvideocapturer_jni.cc View 1 2 2 chunks +12 lines, -6 lines 0 comments Download
M talk/app/webrtc/java/jni/native_handle_impl.h View 1 1 chunk +31 lines, -6 lines 0 comments Download
M talk/app/webrtc/java/jni/native_handle_impl.cc View 1 2 chunks +32 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/jni/surfacetexturehelper_jni.h View 1 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/java/jni/surfacetexturehelper_jni.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java View 1 2 10 chunks +36 lines, -93 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/VideoRenderer.java View 3 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
magjed_webrtc
Please take a look.
5 years, 2 months ago (2015-10-15 11:19:33 UTC) #2
perkj_webrtc
Sad to see this go.. But it is probably the best thing to do until ...
5 years, 2 months ago (2015-10-15 11:31:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394103005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394103005/40001
5 years, 2 months ago (2015-10-15 12:06:37 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-15 12:45:10 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 12:45:21 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/543b6ca30a43eeb069c699291460ce6bacc7959d
Cr-Commit-Position: refs/heads/master@{#10288}

Powered by Google App Engine
This is Rietveld 408576698