talk/app/webrtc/sctputils_unittest.cc - Issue 1393563002: Moving MediaStreamSignaling logic into PeerConnection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/sctputils_unittest.cc

Issue 1393563002: Moving MediaStreamSignaling logic into PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Cleaning up comments, fixing naming, etc. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/sctputils_unittest.cc

diff --git a/talk/app/webrtc/sctputils_unittest.cc b/talk/app/webrtc/sctputils_unittest.cc

index 164f6dd23bd35888a084662f242447e43c94e0b5..93491822a7a110f6701449fe3950c9531c1b7f38 100644

--- a/talk/app/webrtc/sctputils_unittest.cc

+++ b/talk/app/webrtc/sctputils_unittest.cc

@@ -159,3 +159,20 @@ TEST_F(SctpUtilsTest, WriteParseAckMessage) {

EXPECT_TRUE(webrtc::ParseDataChannelOpenAckMessage(packet));

}

+TEST_F(SctpUtilsTest, TestIsOpenMessage) {

+ rtc::ByteBuffer open;

+ open.WriteUInt8(0x03);

+ EXPECT_TRUE(webrtc::IsOpenMessage(open));

+ rtc::ByteBuffer openAck;

+ openAck.WriteUInt8(0x02);

+ EXPECT_FALSE(webrtc::IsOpenMessage(open));

+ rtc::ByteBuffer invalid;

+ openAck.WriteUInt8(0x01);

+ EXPECT_FALSE(webrtc::IsOpenMessage(invalid));

+ rtc::ByteBuffer empty;

+ EXPECT_FALSE(webrtc::IsOpenMessage(empty));

« talk/app/webrtc/peerconnection.cc ('K') | « talk/app/webrtc/sctputils.cc ('k') | talk/app/webrtc/statscollector.h » ('j') | talk/app/webrtc/statscollector.h » ('J')