Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1393553003: Revert "Transport sequence number should be set also for retransmissions." (Closed)

Created:
5 years, 2 months ago by aluebs-webrtc
Modified:
5 years, 2 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, the sun, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Transport sequence number should be set also for retransmissions." After this CL, video_engine_test started failing flakily in different bots for different CLs. TBR=sprang@webrtc.org Committed: https://crrev.com/10950692d67af5cfdcb19d93b40f25193d1db8c6 Cr-Commit-Position: refs/heads/master@{#10188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -27 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 7 chunks +6 lines, -24 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
aluebs-webrtc
Committed patchset #1 (id:1) manually as 10950692d67af5cfdcb19d93b40f25193d1db8c6.
5 years, 2 months ago (2015-10-06 19:27:17 UTC) #1
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 19:27:23 UTC) #2
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10950692d67af5cfdcb19d93b40f25193d1db8c6
Cr-Commit-Position: refs/heads/master@{#10188}

Powered by Google App Engine
This is Rietveld 408576698