Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1393343003: Revert of Remove AudioTrackRenderer (Closed)

Created:
5 years, 2 months ago by torbjorng (webrtc)
Modified:
5 years, 2 months ago
Reviewers:
the sun, tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove AudioTrackRenderer (patchset #3 id:40001 of https://codereview.webrtc.org/1399553003/ ) Reason for revert: Breaks Chrome since its build files were not updated prior to file removal. Original issue's description: > - Remove AudioTrackRenderer. > - Remove AddChannel/RemoveChannel from AudioRenderer interface. > > BUG=webrtc:4690 > > Committed: https://crrev.com/1c0bb386b67835feb5934f503dddfe0912bce3ac > Cr-Commit-Position: refs/heads/master@{#10226} TBR=tommi@webrtc.org,solenberg@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4690 Committed: https://crrev.com/eefbc3bbd7a6962265b028cf259b5028944561d1 Cr-Commit-Position: refs/heads/master@{#10228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -5 lines) Patch
A talk/app/webrtc/audiotrackrenderer.h View 1 chunk +59 lines, -0 lines 0 comments Download
A talk/app/webrtc/audiotrackrenderer.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 4 chunks +15 lines, -1 line 0 comments Download
M talk/libjingle.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M talk/media/base/audiorenderer.h View 1 chunk +14 lines, -0 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 2 chunks +4 lines, -0 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
torbjorng (webrtc)
Created Revert of Remove AudioTrackRenderer
5 years, 2 months ago (2015-10-08 20:10:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393343003/1
5 years, 2 months ago (2015-10-08 20:10:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 20:10:39 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 20:10:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eefbc3bbd7a6962265b028cf259b5028944561d1
Cr-Commit-Position: refs/heads/master@{#10228}

Powered by Google App Engine
This is Rietveld 408576698