Chromium Code Reviews

Issue 1393223005: Cleaning up peerconnection_unittest. (Closed)

Created:
5 years, 2 months ago by Taylor Brandstetter
Modified:
5 years, 2 months ago
Reviewers:
guoweis_webrtc, pthatcher1
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cleaning up peerconnection_unittest. Merging the PeerConnectionTestClientBase and JsepTestClient classes, since there's no real logical distinction. This should make it slightly less painful to write new PeerConnection tests. Committed: https://crrev.com/af1b59cf271854177915342692a78ec0aba61ccd Cr-Commit-Position: refs/heads/master@{#10292}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+330 lines, -392 lines)
M talk/app/webrtc/peerconnection_unittest.cc View 53 chunks +330 lines, -392 lines 0 comments

Messages

Total messages: 8 (2 generated)
Taylor Brandstetter
Guo-wei, since Peter's on vacation would you mind looking at this? It should be just ...
5 years, 2 months ago (2015-10-14 20:53:52 UTC) #2
guoweis_webrtc
On 2015/10/14 20:53:52, Taylor Brandstetter wrote: > Guo-wei, since Peter's on vacation would you mind ...
5 years, 2 months ago (2015-10-14 22:00:37 UTC) #3
pthatcher1
lgtm
5 years, 2 months ago (2015-10-15 05:40:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393223005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393223005/1
5 years, 2 months ago (2015-10-15 17:22:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 19:08:47 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 19:08:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af1b59cf271854177915342692a78ec0aba61ccd
Cr-Commit-Position: refs/heads/master@{#10292}

Powered by Google App Engine