Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1393203005: Add option to print peer connection factory Java stack traces. (Closed)

Created:
5 years, 2 months ago by AlexG
Modified:
5 years, 2 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add option to print peer connection factory Java stack traces. Removing static declaration for media codec thread to allow running multiple HW codec instances. R=wzh@webrtc.org Committed: https://crrev.com/325d414e8cc0990328c49c1d1f4a977f82f90e6a Cr-Commit-Position: refs/heads/master@{#10258}

Patch Set 1 #

Patch Set 2 : Use mediaCodecThread for check #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -20 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 2 chunks +12 lines, -1 line 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java View 7 chunks +32 lines, -2 lines 1 comment Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java View 1 6 chunks +17 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java View 6 chunks +17 lines, -2 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java View 1 chunk +13 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
AlexG
Sorry, PTAL one more time. Reverted static declaration for mediaCodecThread which prevented multiple HW decoder ...
5 years, 2 months ago (2015-10-12 20:13:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393203005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393203005/20001
5 years, 2 months ago (2015-10-12 20:13:33 UTC) #4
wzh
lgtm https://codereview.webrtc.org/1393203005/diff/20001/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java File talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java (right): https://codereview.webrtc.org/1393203005/diff/20001/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java#newcode575 talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java:575: private static void printStackTrace(Thread thread, String threadName) { ...
5 years, 2 months ago (2015-10-12 20:45:48 UTC) #5
AlexG
Committed patchset #2 (id:20001) manually as 325d414e8cc0990328c49c1d1f4a977f82f90e6a (presubmit successful).
5 years, 2 months ago (2015-10-12 21:56:14 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 21:56:18 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/325d414e8cc0990328c49c1d1f4a977f82f90e6a
Cr-Commit-Position: refs/heads/master@{#10258}

Powered by Google App Engine
This is Rietveld 408576698