Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1392903005: Removing M API call for now to green up downstream. (Closed)

Created:
5 years, 2 months ago by phoglund
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing M API call for now to green up downstream. BUG=None Committed: https://crrev.com/c671139ef22875c34368dd72bbdffe76640239bf Cr-Commit-Position: refs/heads/master@{#10219}

Patch Set 1 #

Patch Set 2 : Fix other breakage as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java View 1 1 chunk +7 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
phoglund
5 years, 2 months ago (2015-10-08 12:35:28 UTC) #2
henrika_webrtc
LGTM
5 years, 2 months ago (2015-10-08 12:44:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392903005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392903005/20001
5 years, 2 months ago (2015-10-08 12:48:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-08 13:33:52 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c671139ef22875c34368dd72bbdffe76640239bf Cr-Commit-Position: refs/heads/master@{#10219}
5 years, 2 months ago (2015-10-08 13:34:04 UTC) #7
kjellander (google.com)
Please create a bug to track this and cc henrika@webrtc.org + reference it from the ...
5 years, 2 months ago (2015-10-08 14:59:35 UTC) #9
kjellander (google.com)
On 2015/10/08 14:59:35, kjellander (DO NOT USE THIS) wrote: > Please create a bug to ...
5 years, 2 months ago (2015-10-08 15:07:13 UTC) #10
phoglund
On 2015/10/08 15:07:13, kjellander (DO NOT USE THIS) wrote: > On 2015/10/08 14:59:35, kjellander (DO ...
5 years, 2 months ago (2015-10-08 15:08:37 UTC) #11
kjellander_webrtc
5 years, 2 months ago (2015-10-08 15:13:05 UTC) #12
Message was sent while issue was closed.
On 2015/10/08 15:08:37, phoglund wrote:
> On 2015/10/08 15:07:13, kjellander (DO NOT USE THIS) wrote:
> > On 2015/10/08 14:59:35, kjellander (DO NOT USE THIS) wrote:
> > > Please create a bug to track this and cc mailto:henrika@webrtc.org +
> reference
> > it from
> > > the code.
> > 
> > Ah, it's too late. I'll leave it to you then (if you bother creating a
> follow-up
> > or just is going to make sure you get it fixed in the future).
> 
> Sure, I can make a bug, the question is just if that will help. I think having
> a TODO in the code is reasonable.

You decide, IMHO TODOs are easier to forget than bugs, and it's harder to
reassign them, follow them and loop in additional people...

Powered by Google App Engine
This is Rietveld 408576698