Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(133)

Issue 1392513002: Disable pacer disabling. (Closed)

Created:
3 years, 8 months ago by pbos-webrtc
Modified:
3 years, 8 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, the sun, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable pacer disabling. Since the pacer is always enabled, removing enable/disable which makes all packet queueing succeed. Also renaming one of the ::SendPackets ::InsertPacket to avoid confusion. BUG=webrtc:1695, webrtc:2629 R=stefan@webrtc.org Committed: https://crrev.com/e23e737177cf5d131a6d4a4d229aa513c5270a59 Cr-Commit-Position: refs/heads/master@{#10211}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove RTP FIR + test refactoring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -309 lines) Patch
M webrtc/modules/pacing/include/paced_sender.h View 3 chunks +6 lines, -12 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 5 chunks +35 lines, -53 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 16 chunks +67 lines, -88 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h View 1 3 chunks +7 lines, -13 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 4 chunks +21 lines, -34 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 26 chunks +56 lines, -41 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 2 chunks +2 lines, -22 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 1 1 chunk +1 line, -7 lines 0 comments Download
M webrtc/video_engine/vie_channel.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 3 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
pbos-webrtc
P-to-the-TAL.
3 years, 8 months ago (2015-10-06 14:11:08 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392513002/1
3 years, 8 months ago (2015-10-06 14:11:21 UTC) #3
stefan-webrtc
https://codereview.webrtc.org/1392513002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender.cc File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (right): https://codereview.webrtc.org/1392513002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender.cc#newcode1038 webrtc/modules/rtp_rtcp/source/rtp_sender.cc:1038: if (paced_sender_ && storage != kDontStore) { It worries ...
3 years, 8 months ago (2015-10-06 14:32:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2015-10-06 14:55:22 UTC) #6
pbos-webrtc
Remove RTP FIR + test refactoring
3 years, 8 months ago (2015-10-06 14:58:20 UTC) #7
pbos-webrtc
P-to-the-TAL. https://codereview.webrtc.org/1392513002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender.cc File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (right): https://codereview.webrtc.org/1392513002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender.cc#newcode1038 webrtc/modules/rtp_rtcp/source/rtp_sender.cc:1038: if (paced_sender_ && storage != kDontStore) { On ...
3 years, 8 months ago (2015-10-06 14:58:26 UTC) #8
stefan-webrtc
lgtm
3 years, 8 months ago (2015-10-08 06:57:31 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e23e737177cf5d131a6d4a4d229aa513c5270a59 Cr-Commit-Position: refs/heads/master@{#10211}
3 years, 8 months ago (2015-10-08 09:44:34 UTC) #10
pbos-webrtc
3 years, 8 months ago (2015-10-08 09:44:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e23e737177cf5d131a6d4a4d229aa513c5270a59 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698