Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1392153002: Get rid of deprecated SocketAddress::IsAny() method. (Closed)

Created:
5 years, 2 months ago by tfarina
Modified:
5 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kjellander_webrtc, Sergey Ulanov, tommi
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Get rid of deprecated SocketAddress::IsAny() method. This patch converts the usage of IsAny() to IsAnyIP() and removes the deprecated method. BUG=None R=pthatcher@webrtc.org Committed: https://crrev.com/8ac544e811439f79b2ec0c676f383ddc51ef2ed5 Cr-Commit-Position: refs/heads/master@{#10220}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M webrtc/base/physicalsocketserver.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/socketaddress.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/virtualsocketserver.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/win32socketserver.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transport.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 2 months ago (2015-10-08 02:34:08 UTC) #1
pthatcher1
lgtm
5 years, 2 months ago (2015-10-08 04:22:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392153002/20001
5 years, 2 months ago (2015-10-08 14:14:41 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-08 14:15:48 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 14:15:58 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ac544e811439f79b2ec0c676f383ddc51ef2ed5
Cr-Commit-Position: refs/heads/master@{#10220}

Powered by Google App Engine
This is Rietveld 408576698