Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 1388733002: Remove default receive channel from WVoE; baby step 2. (Closed)

Created:
5 years, 2 months ago by the sun
Modified:
5 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@wvoe_default_rch_a
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove default receive channel from WVoE; baby step 2. Rename voe_channel_ to default_send_channel_id_. BUG=webrtc:4690 Committed: https://crrev.com/8fb30c328b7b5e1ad33e970d1dabca55fdc18926 Cr-Commit-Position: refs/heads/master@{#10261}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -58 lines) Patch
M talk/media/webrtc/webrtcvoiceengine.h View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 2 3 4 27 chunks +52 lines, -42 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 1 2 3 4 4 chunks +5 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
the sun
I want to keep the renaming separate from actual removal of the default receive channel. ...
5 years, 2 months ago (2015-10-05 15:12:16 UTC) #2
pthatcher1
lgtm
5 years, 2 months ago (2015-10-06 18:21:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388733002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388733002/100001
5 years, 2 months ago (2015-10-13 10:02:29 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 2 months ago (2015-10-13 10:07:06 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 10:07:18 UTC) #8
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8fb30c328b7b5e1ad33e970d1dabca55fdc18926
Cr-Commit-Position: refs/heads/master@{#10261}

Powered by Google App Engine
This is Rietveld 408576698