Remove default receive channel from WVoE; baby step 1.

Remove default receive channel from WVoE; baby step 1.

Rx AGC config bits copied from https://codereview.webrtc.org/1315903004.

BUG=webrtc:4690
Committed: https://crrev.com/0b67546d8c080f376565a4c1cedd14947fdbaf2b
Cr-Commit-Position: refs/heads/master@{#10233}

[the sun, 2015-10-05 14:10:56]

solenberg@webrtc.org changed reviewers:
+ andrew@webrtc.org, pthatcher@google.com, tomasl@google.com

[pthatcher1, 2015-10-06 18:19:51]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2015-10-06 18:19:52]

https://codereview.webrtc.org/1388723002/diff/60001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/1388723002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:151: bool ValidateStreamParams(const
StreamParams& sp) {
To go along with VerifyUniquePayloadTypes, you might call this VerifyOneSsrc.

https://codereview.webrtc.org/1388723002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:1575: }
Can we add a unit test for this?

https://codereview.webrtc.org/1388723002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:2342: }
Can we add a unit test to cover that we are setting the options for all receive
streams and not just the default one?

[the sun, 2015-10-07 09:20:35]

solenberg@webrtc.org changed reviewers:
- tomasl@google.com

[the sun, 2015-10-07 10:50:24]

solenberg@webrtc.org changed reviewers:
- pthatcher@google.com

[the sun, 2015-10-07 10:50:25]

https://codereview.webrtc.org/1388723002/diff/60001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/1388723002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:151: bool ValidateStreamParams(const
StreamParams& sp) {
On 2015/10/06 18:19:52, pthatcher1 wrote:
> To go along with VerifyUniquePayloadTypes, you might call this VerifyOneSsrc.

That may not be the only thing it checks, going forward. I'm using the same name
as we do in WebRtcVideoChannel2.

https://codereview.webrtc.org/1388723002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:1575: }
On 2015/10/06 18:19:52, pthatcher1 wrote:
> Can we add a unit test for this?

There is one already:
WebRtcVoiceEngineTestFake.SetRecvCodecsDuplicatePayloadType

[pthatcher1, 2015-10-07 16:02:29]

Everything looks good, except could we add a unit test to make sure
SetRecvOptions is called on all of the receive channels?

[the sun, 2015-10-07 16:11:47]

On 2015/10/07 16:02:29, pthatcher1 wrote:
> Everything looks good, except could we add a unit test to make sure
> SetRecvOptions is called on all of the receive channels?

Did you look at the correct patch set? I've removed SetRecvOptions. :)

[the sun, 2015-10-07 18:32:35]

On 2015/10/07 16:11:47, the sun wrote:
> On 2015/10/07 16:02:29, pthatcher1 wrote:
> > Everything looks good, except could we add a unit test to make sure
> > SetRecvOptions is called on all of the receive channels?
> 
> Did you look at the correct patch set? I've removed SetRecvOptions. :)

Andrew, are you ok with this?

[pthatcher1, 2015-10-07 19:54:57]

lgtm

[the sun, 2015-10-09 07:50:22]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-10-09 07:50:22]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1388723002/#ps160001 (title:
"rebase")

[commit-bot: I haz the power, 2015-10-09 07:50:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1388723002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1388723002/160001

[the sun, 2015-10-09 07:55:36]

solenberg@webrtc.org changed reviewers:
- andrew@webrtc.org

[commit-bot: I haz the power, 2015-10-09 08:37:15]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-10-09 08:37:28]

Patchset 9 (id:??) landed as
https://crrev.com/0b67546d8c080f376565a4c1cedd14947fdbaf2b
Cr-Commit-Position: refs/heads/master@{#10233}