Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1388203004: Suppressing TestUdpReadyToSendIPv4 on ASan. (Closed)

Created:
5 years, 2 months ago by minyue-webrtc
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Suppressing TestUdpReadyToSendIPv4 on ASan. The test is flaky on Asan. BUG=webrtc:4958 Committed: https://crrev.com/df200d1ef7af4b750f6af21d7a0989509c144328 Cr-Commit-Position: refs/heads/master@{#10313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M webrtc/base/physicalsocketserver_unittest.cc View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
minyue-webrtc
Hi Peter, Would you review this small CL? A similar one was reviewed by you ...
5 years, 2 months ago (2015-10-12 15:43:14 UTC) #2
minyue-webrtc
On 2015/10/12 15:43:14, minyue-webrtc wrote: > Hi Peter, > > Would you review this small ...
5 years, 2 months ago (2015-10-14 19:40:26 UTC) #3
minyue-webrtc
+perkj
5 years, 2 months ago (2015-10-16 09:50:17 UTC) #5
pthatcher1
lgtm
5 years, 2 months ago (2015-10-16 21:41:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388203004/1
5 years, 2 months ago (2015-10-17 19:22:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-17 20:10:50 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-17 20:11:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df200d1ef7af4b750f6af21d7a0989509c144328
Cr-Commit-Position: refs/heads/master@{#10313}

Powered by Google App Engine
This is Rietveld 408576698