Remove default receive channel from WVoE; baby step 0.

Remove default receive channel from WVoE; baby step 0.

Cleanup + add thread checker DCHECKs to various method in WebRtcVoiceEngine/MediaChannel.

BUG=webrtc:4690
Committed: https://crrev.com/d97ec30ce4f22ba2d88314d67ff44458144a5096
Cr-Commit-Position: refs/heads/master@{#10194}

[the sun, 2015-10-02 15:25:33]

solenberg@webrtc.org changed reviewers:
+ pthatcher@google.com

[the sun, 2015-10-02 15:25:33]

Created this CL to separate the cleanup stuff from the guts of the default
receive channel CL.

[pthatcher1, 2015-10-02 18:39:33]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2015-10-02 18:39:34]

https://codereview.webrtc.org/1386653002/diff/20001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/1386653002/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:1179: void
WebRtcVoiceEngine::CallbackOnError(int channel_num, int err_code) {
channel_id?

https://codereview.webrtc.org/1386653002/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:1180: RTC_DCHECK(channel_num == -1);
This seems strange to me.  We're certain the callback will always have a
channel_id of -1?

https://codereview.webrtc.org/1386653002/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:2966: if (send_ != SEND_NOTHING) {
An early return might look nicer:

if (send_ == SEND_NOTHING) {
  return;
}

...

[the sun, 2015-10-05 12:09:18]

https://codereview.webrtc.org/1386653002/diff/20001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/1386653002/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:1179: void
WebRtcVoiceEngine::CallbackOnError(int channel_num, int err_code) {
On 2015/10/02 18:39:34, pthatcher1 wrote:
> channel_id?

Done.

https://codereview.webrtc.org/1386653002/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:1180: RTC_DCHECK(channel_num == -1);
On 2015/10/02 18:39:34, pthatcher1 wrote:
> This seems strange to me.  We're certain the callback will always have a
> channel_id of -1?

AFAICT there are 4 call sites, and they all use -1 for this parameter (grep for
CallbackOnError).

https://codereview.webrtc.org/1386653002/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:2966: if (send_ != SEND_NOTHING) {
On 2015/10/02 18:39:34, pthatcher1 wrote:
> An early return might look nicer:
> 
> if (send_ == SEND_NOTHING) {
>   return;
> }
> 
> ...
> 
> 
> 
> 

Done.

[pthatcher1, 2015-10-06 18:14:40]

lgtm

I like how you are breaking these up.  Thank you.

[the sun, 2015-10-06 20:31:45]

solenberg@webrtc.org changed reviewers:
- pthatcher@google.com

[the sun, 2015-10-07 07:48:51]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-10-07 07:48:51]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1386653002/#ps80001 (title:
"rebase")

[commit-bot: I haz the power, 2015-10-07 07:48:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386653002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386653002/80001

[commit-bot: I haz the power, 2015-10-07 08:40:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-07 08:40:49]

Patchset 5 (id:??) landed as
https://crrev.com/d97ec30ce4f22ba2d88314d67ff44458144a5096
Cr-Commit-Position: refs/heads/master@{#10194}