Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1386613003: Fix file order in base.gyp. (Closed)

Created:
5 years, 2 months ago by Henrik Grunell WebRTC
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix file order in base.gyp. Committed: https://crrev.com/990d57dc6569dee924c702011d160dfad0878d81 Cr-Commit-Position: refs/heads/master@{#10164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/base/base.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Henrik Grunell WebRTC
5 years, 2 months ago (2015-10-05 07:35:11 UTC) #2
kjellander (google.com)
lgtm Kind of waste to run all trybots for this patch, but I guess you're ...
5 years, 2 months ago (2015-10-05 07:40:23 UTC) #4
Henrik Grunell WebRTC
On 2015/10/05 07:40:23, kjellander (DO NOT USE THIS) wrote: > lgtm > > Kind of ...
5 years, 2 months ago (2015-10-05 07:42:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386613003/1
5 years, 2 months ago (2015-10-05 07:42:24 UTC) #7
kjellander_webrtc
lgtm with the right account.
5 years, 2 months ago (2015-10-05 08:17:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 08:22:31 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 08:22:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/990d57dc6569dee924c702011d160dfad0878d81
Cr-Commit-Position: refs/heads/master@{#10164}

Powered by Google App Engine
This is Rietveld 408576698