Fix MSVS project files generation.

Fix MSVS project files generation.

BUG=5044
TBR=kjellander@webrtc.org
TEST=Runhooks with GYP_GENERATORS=msvs-ninja

Committed: https://crrev.com/9dff0ba8c15648f13a75469b7fbb90247f6a1a6b
Cr-Commit-Position: refs/heads/master@{#10151}

[Henrik Grunell WebRTC, 2015-10-02 13:09:43]

henrikg@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[Henrik Grunell WebRTC, 2015-10-02 13:09:56]

The CQ bit was checked by henrikg@webrtc.org

[commit-bot: I haz the power, 2015-10-02 13:10:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386613002/1

[commit-bot: I haz the power, 2015-10-02 15:10:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-02 15:10:21]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[Henrik Grunell WebRTC, 2015-10-02 17:06:38]

The CQ bit was checked by henrikg@webrtc.org

[commit-bot: I haz the power, 2015-10-02 17:06:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386613002/1

[commit-bot: I haz the power, 2015-10-02 17:07:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-02 17:08:09]

Patchset 1 (id:??) landed as
https://crrev.com/9dff0ba8c15648f13a75469b7fbb90247f6a1a6b
Cr-Commit-Position: refs/heads/master@{#10151}

[kjellander_webrtc, 2015-10-03 17:06:30]

Thanks for fixing this. I always wondered why these include+exclude configs ever
were added in the first place.

lgtm

https://codereview.webrtc.org/1386613002/diff/1/webrtc/base/base.gyp
File webrtc/base/base.gyp (right):

https://codereview.webrtc.org/1386613002/diff/1/webrtc/base/base.gyp#newcode381
webrtc/base/base.gyp:381:
'../../webrtc_overrides/webrtc/base/win32socketinit.cc',
nit: sort alphabetically.

[Henrik Grunell WebRTC, 2015-10-05 07:29:32]

The include-exclude style is (was?) recommended so that MSVS shows all files in
the UI, also posix etc., as a reference, but they are disabled. That doesn't
make sense however in this case.

https://codereview.webrtc.org/1386613002/diff/1/webrtc/base/base.gyp
File webrtc/base/base.gyp (right):

https://codereview.webrtc.org/1386613002/diff/1/webrtc/base/base.gyp#newcode381
webrtc/base/base.gyp:381:
'../../webrtc_overrides/webrtc/base/win32socketinit.cc',
On 2015/10/03 17:06:30, kjellander (webrtc) wrote:
> nit: sort alphabetically.

Will fix in follow-up.