Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1386183002: Fix VS 2015 warning by adding an additional cast (Closed)

Created:
5 years, 2 months ago by brucedawson
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix VS 2015 warning by adding an additional cast The OwningThread member of CRITICAL_SECTION is declared as having type HANDLE but it is actually the thread's Thread ID which is a DWORD. When doing 64-bit builds of Chromium with VS 2015 this triggers a warning because of the suspicious conversion from 32-bit integer to 64-bit pointer. This change adds a cast (and some comments) to make the conversion explicit and avoid the warning. R=henrikg@webrtc.org BUG=440500 Committed: https://crrev.com/a10492ff33152cef5a835761125219d3e4ee21d0 Cr-Commit-Position: refs/heads/master@{#10190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M webrtc/base/criticalsection.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Henrik Grunell WebRTC
lgtm
5 years, 2 months ago (2015-10-06 19:47:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386183002/1
5 years, 2 months ago (2015-10-06 19:50:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 20:34:37 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 20:34:39 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a10492ff33152cef5a835761125219d3e4ee21d0
Cr-Commit-Position: refs/heads/master@{#10190}

Powered by Google App Engine
This is Rietveld 408576698