Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1384923002: SurfaceTextureHelper fixes (Closed)

Created:
5 years, 2 months ago by perkj_webrtc
Modified:
5 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

SurfaceTextureHelper fixes Fixed a problem where eglBase.makecurrent() could be called after the context had been released if SurfaceTextureHelper was first created and immedately disconnected. Add the possibility to inject a thread to use instead of creating a new. BUG=webrtc:4993 R=magjed@webrtc.org Committed: https://crrev.com/1b33da1298809535348f42ed4d3db23e393e32ee Cr-Commit-Position: refs/heads/master@{#10174}

Patch Set 1 #

Total comments: 27

Patch Set 2 : Addressed comments. #

Patch Set 3 : Rebased and removed unused import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -11 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java View 1 2 3 chunks +62 lines, -1 line 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/SurfaceTextureHelper.java View 1 6 chunks +28 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
perkj_webrtc
please?
5 years, 2 months ago (2015-10-05 09:29:24 UTC) #2
magjed_webrtc
https://codereview.webrtc.org/1384923002/diff/1/talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java File talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java (right): https://codereview.webrtc.org/1384923002/diff/1/talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java#newcode275 talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java:275: @SmallTest I still think this is a MediumTest because ...
5 years, 2 months ago (2015-10-05 10:13:55 UTC) #3
perkj_webrtc
PTAL https://codereview.webrtc.org/1384923002/diff/1/talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java File talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java (right): https://codereview.webrtc.org/1384923002/diff/1/talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java#newcode276 talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java:276: public static void testDisconnectImmediately() throws InterruptedException { On ...
5 years, 2 months ago (2015-10-05 12:14:18 UTC) #4
magjed_webrtc
lgtm https://codereview.webrtc.org/1384923002/diff/1/talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java File talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java (right): https://codereview.webrtc.org/1384923002/diff/1/talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java#newcode279 talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java:279: new SurfaceTextureHelper(eglBase.getContext()); On 2015/10/05 12:14:17, perkj1 wrote: > ...
5 years, 2 months ago (2015-10-05 16:15:11 UTC) #5
perkj_webrtc
Committed patchset #3 (id:40001) manually as 1b33da1298809535348f42ed4d3db23e393e32ee (presubmit successful).
5 years, 2 months ago (2015-10-05 19:06:54 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 19:06:58 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1b33da1298809535348f42ed4d3db23e393e32ee
Cr-Commit-Position: refs/heads/master@{#10174}

Powered by Google App Engine
This is Rietveld 408576698