Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1384303002: Add ThreadChecker class to ThreadUtils (Closed)

Created:
5 years, 2 months ago by perkj_webrtc
Modified:
5 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add ThreadChecker class to ThreadUtils This class can be used for checking that method calls are made on the correct thread. R=magjed@webrtc.org Committed: https://crrev.com/418503275c52dba03c1c9dffec8aabfacd33421e Cr-Commit-Position: refs/heads/master@{#10173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
perkj_webrtc
please?
5 years, 2 months ago (2015-10-05 14:14:31 UTC) #2
magjed_webrtc
lgtm! I look forward to using this.
5 years, 2 months ago (2015-10-05 14:31:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384303002/1
5 years, 2 months ago (2015-10-05 14:46:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
5 years, 2 months ago (2015-10-05 16:47:00 UTC) #7
perkj_webrtc
Committed patchset #1 (id:1) manually as 418503275c52dba03c1c9dffec8aabfacd33421e (presubmit successful).
5 years, 2 months ago (2015-10-05 18:49:23 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 18:49:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/418503275c52dba03c1c9dffec8aabfacd33421e
Cr-Commit-Position: refs/heads/master@{#10173}

Powered by Google App Engine
This is Rietveld 408576698