Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1383983003: Android MediaCodecVideoDecoder: Cleanup to prepare for texture liftime management (Closed)

Created:
5 years, 2 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android MediaCodecVideoDecoder: Cleanup to prepare for texture liftime management This CL should not change the behaviour of the decoder. The purpose is to prepare for lifetime management of textures received from the SurfaceTexture. The main change is to only use exceptions for error signaling in MediaCodecVideoDecoder.dequeueOutputBuffer() and MediaCodecVideoDecoder.releaseOutputBuffer(), not both exceptions and error return values. BUG=webrtc:4993 R=perkj@webrtc.org Committed: https://crrev.com/7e319372abd4403565aa3d27a2d1bfa069969b19 Cr-Commit-Position: refs/heads/master@{#10148}

Patch Set 1 : #

Patch Set 2 : Replace CallBooleanMethod() with CallVoidMethod() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -65 lines) Patch
M talk/app/webrtc/java/jni/androidmediadecoder_jni.cc View 1 4 chunks +6 lines, -8 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java View 10 chunks +43 lines, -57 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
magjed_webrtc
perkj - Please take a look.
5 years, 2 months ago (2015-10-02 08:28:02 UTC) #3
perkj_webrtc
On 2015/10/02 08:28:02, magjed_webrtc wrote: > perkj - Please take a look. lgtm
5 years, 2 months ago (2015-10-02 12:50:03 UTC) #4
magjed_webrtc
Committed patchset #2 (id:40001) manually as 7e319372abd4403565aa3d27a2d1bfa069969b19 (presubmit successful).
5 years, 2 months ago (2015-10-02 13:49:54 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 13:49:59 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e319372abd4403565aa3d27a2d1bfa069969b19
Cr-Commit-Position: refs/heads/master@{#10148}

Powered by Google App Engine
This is Rietveld 408576698