Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1383533002: Update VP8 settings to avoid spending bitrate on static areas. PERF NOTE (Closed)

Created:
5 years, 2 months ago by sprang_webrtc
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update VP8 settings to avoid spending bitrate on static areas. PERF NOTE This CL changes the threshold where we consider a block to be static and of sufficient quality to not spend bits/CPU encoding it. Perf note: This change may result in a minor degradation of PSNR/SSIM and available send bitrate. CPU usage and bitrate sent should however be greately reduced. BUG=webrtc:5015 Committed: https://crrev.com/fb30c1b5d1effcc82a96fdf40814a03baf0727bf Cr-Commit-Position: refs/heads/master@{#10134}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
sprang_webrtc
After manual visual tuning I set the STATIC_THRESHOLD to 300, seems to be reasonable trade-off ...
5 years, 2 months ago (2015-09-30 13:15:00 UTC) #2
marpan
one comment, and lgtm. https://codereview.webrtc.org/1383533002/diff/1/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/1383533002/diff/1/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc#newcode667 webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:667: vpx_codec_control(&(encoders_[i]), VP8E_SET_STATIC_THRESHOLD, 300); condition this ...
5 years, 2 months ago (2015-09-30 15:45:30 UTC) #4
stefan-webrtc
lgtm
5 years, 2 months ago (2015-10-01 08:54:27 UTC) #5
sprang_webrtc
https://codereview.webrtc.org/1383533002/diff/1/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/1383533002/diff/1/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc#newcode667 webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:667: vpx_codec_control(&(encoders_[i]), VP8E_SET_STATIC_THRESHOLD, 300); On 2015/09/30 15:45:30, marpan wrote: > ...
5 years, 2 months ago (2015-10-01 11:17:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383533002/20001
5 years, 2 months ago (2015-10-01 11:17:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/6932)
5 years, 2 months ago (2015-10-01 11:56:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383533002/20001
5 years, 2 months ago (2015-10-01 13:25:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 13:26:16 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 13:26:24 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb30c1b5d1effcc82a96fdf40814a03baf0727bf
Cr-Commit-Position: refs/heads/master@{#10134}

Powered by Google App Engine
This is Rietveld 408576698