Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1383253002: Get rid of SCHANNEL code. (Closed)

Created:
5 years, 2 months ago by torbjorng (webrtc)
Modified:
5 years, 2 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Get rid of SCHANNEL code. BUG=webrtc:5045 Committed: https://crrev.com/172f009be2d6b897b1fce952f19a6c5dd842fc86 Cr-Commit-Position: refs/heads/master@{#10199}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -860 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/base.gyp View 1 2 chunks +0 lines, -4 lines 0 comments Download
D webrtc/base/schanneladapter.h View 1 chunk +0 lines, -79 lines 0 comments Download
D webrtc/base/schanneladapter.cc View 1 chunk +0 lines, -714 lines 0 comments Download
M webrtc/base/ssladapter.cc View 3 chunks +6 lines, -12 lines 0 comments Download
M webrtc/base/sslidentity.cc View 3 chunks +5 lines, -27 lines 0 comments Download
M webrtc/base/sslstreamadapter.cc View 1 4 chunks +7 lines, -22 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383253002/1
5 years, 2 months ago (2015-10-05 14:30:09 UTC) #2
torbjorng (webrtc)
The SCHANNEL code suffers is incomplete and also suffers from bitrot as we don't test ...
5 years, 2 months ago (2015-10-05 15:08:33 UTC) #4
torbjorng (webrtc)
PTAL tommi.
5 years, 2 months ago (2015-10-05 15:09:04 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) ...
5 years, 2 months ago (2015-10-05 16:30:34 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383253002/1
5 years, 2 months ago (2015-10-06 13:33:28 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1111)
5 years, 2 months ago (2015-10-06 13:35:12 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383253002/20001
5 years, 2 months ago (2015-10-06 14:52:25 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-06 15:37:46 UTC) #15
torbjorng (webrtc)
Note that the bot failures here do not indicate a problem with this CL. The ...
5 years, 2 months ago (2015-10-06 15:42:49 UTC) #16
kjellander_chromium
On 2015/10/06 15:42:49, torbjorng (webrtc) wrote: > Note that the bot failures here do not ...
5 years, 2 months ago (2015-10-07 11:53:00 UTC) #17
kjellander_webrtc
On 2015/10/07 11:53:00, kjellander (chromium) wrote: > On 2015/10/06 15:42:49, torbjorng (webrtc) wrote: > > ...
5 years, 2 months ago (2015-10-07 11:53:37 UTC) #18
tommi
On 2015/10/07 11:53:00, kjellander (chromium) wrote: > On 2015/10/06 15:42:49, torbjorng (webrtc) wrote: > > ...
5 years, 2 months ago (2015-10-07 11:54:38 UTC) #19
tommi
lgtm
5 years, 2 months ago (2015-10-07 11:55:02 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383253002/20001
5 years, 2 months ago (2015-10-07 11:55:16 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-07 11:58:00 UTC) #23
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 11:58:07 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/172f009be2d6b897b1fce952f19a6c5dd842fc86
Cr-Commit-Position: refs/heads/master@{#10199}

Powered by Google App Engine
This is Rietveld 408576698