Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 1381963003: autoroller: Always roll and improve description (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

autoroller: Always roll and improve description In order to minimize bisection ranges when the roll breaks, we want to update the chromium_revision as often as possible. Even if a roll doesn't bring in changed dependencies or Clang version, it still brings in changes in the Chromium build toolchain. The description now contains links to all dependencies that change (if any). BUG=webrtc:4688 R=phoglund@webrtc.org Committed: https://crrev.com/a9c584d4652641707f4b7abefaa3acdb1bc5866f Cr-Commit-Position: refs/heads/master@{#10141}

Patch Set 1 #

Patch Set 2 : Made CL description clearer when no deps or Clang changes. #

Total comments: 4

Patch Set 3 : Rebase and git number -> commit position #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -27 lines) Patch
M tools/autoroller/roll_chromium_revision.py View 1 2 6 chunks +46 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kjellander_webrtc
With this CL, the commit message of https://chromium.googlesource.com/external/webrtc/+/edba998cf16f500e258d25149584caa1b2ca9af6 would look like this (except the manually ...
5 years, 2 months ago (2015-10-01 17:05:18 UTC) #2
phoglund
lgtm https://codereview.webrtc.org/1381963003/diff/20001/tools/autoroller/roll_chromium_revision.py File tools/autoroller/roll_chromium_revision.py (right): https://codereview.webrtc.org/1381963003/diff/20001/tools/autoroller/roll_chromium_revision.py#newcode397 tools/autoroller/roll_chromium_revision.py:397: current_git_number = ParseCommitPosition(ReadRemoteCrCommit(current_cr_rev)) Nit: current_git_pos or current_commit_pos? That ...
5 years, 2 months ago (2015-10-02 06:53:43 UTC) #3
kjellander_webrtc
Comments adressed. https://codereview.webrtc.org/1381963003/diff/20001/tools/autoroller/roll_chromium_revision.py File tools/autoroller/roll_chromium_revision.py (right): https://codereview.webrtc.org/1381963003/diff/20001/tools/autoroller/roll_chromium_revision.py#newcode397 tools/autoroller/roll_chromium_revision.py:397: current_git_number = ParseCommitPosition(ReadRemoteCrCommit(current_cr_rev)) On 2015/10/02 06:53:42, phoglund ...
5 years, 2 months ago (2015-10-02 07:10:37 UTC) #4
kjellander_webrtc
Committed patchset #3 (id:40001) manually as a9c584d4652641707f4b7abefaa3acdb1bc5866f (presubmit successful).
5 years, 2 months ago (2015-10-02 07:12:14 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 07:12:17 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a9c584d4652641707f4b7abefaa3acdb1bc5866f
Cr-Commit-Position: refs/heads/master@{#10141}

Powered by Google App Engine
This is Rietveld 408576698