Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: webrtc/video/rampup_tests.cc

Issue 1380483002: Fix bug in ramp-up tests stats where rtx was accounted for in the media ssrc. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/rampup_tests.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/rampup_tests.cc
diff --git a/webrtc/video/rampup_tests.cc b/webrtc/video/rampup_tests.cc
index ec014206bd0289909e97afe7c302e7efa5283900..25352e47edb50455ce2f5b85778dca715d1833fb 100644
--- a/webrtc/video/rampup_tests.cc
+++ b/webrtc/video/rampup_tests.cc
@@ -210,11 +210,11 @@ void RampUpTester::ReportResult(const std::string& measurement,
value, units, false);
}
-void RampUpTester::GetStats(const VideoSendStream::StreamStats& stream,
- size_t* total_packets_sent,
- size_t* total_sent,
- size_t* padding_sent,
- size_t* media_sent) const {
+void RampUpTester::AccumulateStats(const VideoSendStream::StreamStats& stream,
+ size_t* total_packets_sent,
+ size_t* total_sent,
+ size_t* padding_sent,
+ size_t* media_sent) const {
*total_packets_sent += stream.rtp_stats.transmitted.packets +
stream.rtp_stats.retransmitted.packets +
stream.rtp_stats.fec.packets;
@@ -235,8 +235,8 @@ void RampUpTester::TriggerTestDone() {
size_t padding_sent = 0;
size_t media_sent = 0;
for (uint32_t ssrc : ssrcs_) {
- GetStats(send_stats.substreams[ssrc], &total_packets_sent, &total_sent,
- &padding_sent, &media_sent);
+ AccumulateStats(send_stats.substreams[ssrc], &total_packets_sent,
+ &total_sent, &padding_sent, &media_sent);
}
size_t rtx_total_packets_sent = 0;
@@ -244,8 +244,8 @@ void RampUpTester::TriggerTestDone() {
size_t rtx_padding_sent = 0;
size_t rtx_media_sent = 0;
for (uint32_t rtx_ssrc : rtx_ssrcs_) {
- GetStats(send_stats.substreams[rtx_ssrc], &total_packets_sent, &total_sent,
- &padding_sent, &media_sent);
+ AccumulateStats(send_stats.substreams[rtx_ssrc], &rtx_total_packets_sent,
+ &rtx_total_sent, &rtx_padding_sent, &rtx_media_sent);
}
ReportResult("ramp-up-total-packets-sent", total_packets_sent, "packets");
« no previous file with comments | « webrtc/video/rampup_tests.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698