talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java - Issue 1379793003: Android SurfaceViewRenderer: Add tests for onMeasure()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java

Issue 1379793003: Android SurfaceViewRenderer: Add tests for onMeasure() (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Change I420Frame constructors to package private Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « talk/app/webrtc/androidtests/src/org/webrtc/SurfaceViewRendererOnMeasureTest.java ('k') | talk/app/webrtc/java/src/org/webrtc/VideoRenderer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java

diff --git a/talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java b/talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java

index 28404c9d6f13782562dd3d2c635e2a8a5e7defa4..034bbb90fbc62d6eef8363e14c433703402e8e80 100644

--- a/talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java

+++ b/talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java

@@ -311,9 +311,9 @@ public class SurfaceViewRenderer extends SurfaceView

synchronized (layoutLock) {

this.widthSpec = widthSpec;

this.heightSpec = heightSpec;

+ final Point size = getDesiredLayoutSize();

+ setMeasuredDimension(size.x, size.y);

}

- final Point size = getDesiredLayoutSize();

- setMeasuredDimension(size.x, size.y);

}

@Override