Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1379583002: Objective-C++ style guide changes for iOS ADM (Closed)

Created:
5 years, 2 months ago by henrika_webrtc
Modified:
5 years, 2 months ago
Reviewers:
tommi, tkchin_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Objective-C++ style guide changes for iOS ADM BUG=NONE Committed: https://crrev.com/8c471e7bdfc3bd420d19af118b2bdf8fd716288e Cr-Commit-Position: refs/heads/master@{#10135}

Patch Set 1 #

Patch Set 2 : More changes #

Total comments: 5

Patch Set 3 : feedback from tkchin@ #

Total comments: 2

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -255 lines) Patch
M webrtc/modules/audio_device/ios/audio_device_ios.h View 1 2 3 7 chunks +47 lines, -46 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 1 2 13 chunks +212 lines, -209 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
henrika_webrtc
PTAL (as discussed in previous CL)
5 years, 2 months ago (2015-09-29 14:34:16 UTC) #2
tkchin_webrtc
lgtm Thanks for doing this! https://codereview.webrtc.org/1379583002/diff/20001/webrtc/modules/audio_device/ios/audio_device_ios.h File webrtc/modules/audio_device/ios/audio_device_ios.h (right): https://codereview.webrtc.org/1379583002/diff/20001/webrtc/modules/audio_device/ios/audio_device_ios.h#newcode148 webrtc/modules/audio_device/ios/audio_device_ios.h:148: void ClearPlayoutWarning() override{}; nit: ...
5 years, 2 months ago (2015-10-01 00:37:35 UTC) #3
henrika_webrtc
Thanks. Landing.
5 years, 2 months ago (2015-10-01 10:38:58 UTC) #4
henrika_webrtc
https://codereview.webrtc.org/1379583002/diff/20001/webrtc/modules/audio_device/ios/audio_device_ios.h File webrtc/modules/audio_device/ios/audio_device_ios.h (right): https://codereview.webrtc.org/1379583002/diff/20001/webrtc/modules/audio_device/ios/audio_device_ios.h#newcode148 webrtc/modules/audio_device/ios/audio_device_ios.h:148: void ClearPlayoutWarning() override{}; On 2015/10/01 00:37:35, tkchin_webrtc wrote: > ...
5 years, 2 months ago (2015-10-01 10:39:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379583002/40001
5 years, 2 months ago (2015-10-01 10:39:19 UTC) #8
tommi
one nit... https://codereview.webrtc.org/1379583002/diff/40001/webrtc/modules/audio_device/ios/audio_device_ios.h File webrtc/modules/audio_device/ios/audio_device_ios.h (right): https://codereview.webrtc.org/1379583002/diff/40001/webrtc/modules/audio_device/ios/audio_device_ios.h#newcode148 webrtc/modules/audio_device/ios/audio_device_ios.h:148: void ClearPlayoutWarning() override {}; remove semicolons
5 years, 2 months ago (2015-10-01 10:52:52 UTC) #10
henrika_webrtc
Done https://codereview.webrtc.org/1379583002/diff/40001/webrtc/modules/audio_device/ios/audio_device_ios.h File webrtc/modules/audio_device/ios/audio_device_ios.h (right): https://codereview.webrtc.org/1379583002/diff/40001/webrtc/modules/audio_device/ios/audio_device_ios.h#newcode148 webrtc/modules/audio_device/ios/audio_device_ios.h:148: void ClearPlayoutWarning() override {}; Thanks ;-)
5 years, 2 months ago (2015-10-01 11:01:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379583002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379583002/60001
5 years, 2 months ago (2015-10-01 11:01:39 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-01 14:36:52 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 14:37:02 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8c471e7bdfc3bd420d19af118b2bdf8fd716288e
Cr-Commit-Position: refs/heads/master@{#10135}

Powered by Google App Engine
This is Rietveld 408576698