Android MediaCodecVideoDecoder: Split DecoderOutputBufferInfo into DecodedByteBuffer and DecodedTex…

Android MediaCodecVideoDecoder: Split DecoderOutputBufferInfo into DecodedByteBuffer and DecodedTextureBuffer

This CL separates the types and code paths for textures vs byte buffers in MediaCodecVideoDecoder.dequeueOutputBuffer() and MediaCodecVideoDecoder::DeliverPendingOutputs(). The purpose is to prepare for lifetime management of textures received from the SurfaceTexture.

This CL is a part of the plan in https://codereview.webrtc.org/1357923002/.

BUG=webrtc:4993
Committed: https://crrev.com/44bf6f5f67ab6b6677e3cd1cceb954c2426f930a
Cr-Commit-Position: refs/heads/master@{#10156}

[magjed_webrtc, 2015-10-02 14:12:32]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2015-10-02 14:42:37]

magjed@webrtc.org changed reviewers:
+ perkj@webrtc.org

[magjed_webrtc, 2015-10-02 14:42:53]

perkj - Please take a look.

[perkj_webrtc, 2015-10-02 15:25:22]

lgtm %nits

https://codereview.webrtc.org/1379383002/diff/20001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/androidmediadecoder_jni.cc (right):

https://codereview.webrtc.org/1379383002/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediadecoder_jni.cc:585: long
output_timestamps_ms;
nit set = 0 and move just before the if statement

https://codereview.webrtc.org/1379383002/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java (right):

https://codereview.webrtc.org/1379383002/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java:318: // Helper
struct for dequeueOutputBuffer() below.
nit: remove unnecessary comment.

https://codereview.webrtc.org/1379383002/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java:394: throw new
IllegalStateException("releaseByteBuffer() called for surface decoding.");
you mean  returnDecodedByteBuffer right?

[magjed_webrtc, 2015-10-03 08:18:11]

https://codereview.webrtc.org/1379383002/diff/20001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/androidmediadecoder_jni.cc (right):

https://codereview.webrtc.org/1379383002/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediadecoder_jni.cc:585: long
output_timestamps_ms;
On 2015/10/02 15:25:22, perkj1 wrote:
> nit set = 0 and move just before the if statement

Done.

https://codereview.webrtc.org/1379383002/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java (right):

https://codereview.webrtc.org/1379383002/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java:318: // Helper
struct for dequeueOutputBuffer() below.
On 2015/10/02 15:25:22, perkj1 wrote:
> nit: remove unnecessary comment.

Done.

https://codereview.webrtc.org/1379383002/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java:394: throw new
IllegalStateException("releaseByteBuffer() called for surface decoding.");
On 2015/10/02 15:25:22, perkj1 wrote:
> you mean  returnDecodedByteBuffer right? 

Yes, done.

[magjed_webrtc, 2015-10-03 08:20:07]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2015-10-03 08:20:08]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1379383002/#ps40001 (title:
"Addressing perkj@s comments")

[commit-bot: I haz the power, 2015-10-03 08:20:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1379383002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1379383002/40001

[commit-bot: I haz the power, 2015-10-03 09:08:04]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-10-03 09:08:15]

Patchset 2 (id:??) landed as
https://crrev.com/44bf6f5f67ab6b6677e3cd1cceb954c2426f930a
Cr-Commit-Position: refs/heads/master@{#10156}