Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1379123002: Removed unused API functions in AudioProcessing and AudioProcessingModule (Closed)

Created:
5 years, 2 months ago by peah-webrtc
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, hlundin-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed unused API functions in AudioProcessing and AudioProcessingModule BUG= Committed: https://crrev.com/5aaa9b4fe454195df1def4ebd36301a706fdd8d8 Cr-Commit-Position: refs/heads/master@{#10138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -48 lines) Patch
M talk/media/webrtc/fakewebrtcvoiceengine.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 4 chunks +0 lines, -26 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 3 chunks +0 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
peah-webrtc
I found some APM API functions that were not used anywhere and this CL is ...
5 years, 2 months ago (2015-10-01 10:47:29 UTC) #2
the sun
lgtm
5 years, 2 months ago (2015-10-01 10:52:17 UTC) #3
Andrew MacDonald
lgtm
5 years, 2 months ago (2015-10-02 04:48:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379123002/1
5 years, 2 months ago (2015-10-02 06:15:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 06:58:18 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 06:58:27 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5aaa9b4fe454195df1def4ebd36301a706fdd8d8
Cr-Commit-Position: refs/heads/master@{#10138}

Powered by Google App Engine
This is Rietveld 408576698