Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1378353005: Fix a build issue when use external OpenSSL. (Closed)

Created:
5 years, 2 months ago by jianjunz
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a build issue when use external OpenSSL. R=juberti@google.com TBR=juberti@webrtc.org BUG=webrtc:5049 Committed: https://crrev.com/42b4faa28afed9e9358c97aae85f0ef742afa196 Cr-Commit-Position: refs/heads/master@{#10159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M webrtc/base/opensslstreamadapter.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378353005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378353005/1
5 years, 2 months ago (2015-10-04 15:12:24 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 2 months ago (2015-10-04 15:12:25 UTC) #4
jianjunz
Please take a look.
5 years, 2 months ago (2015-10-04 15:27:17 UTC) #7
juberti
lgtm
5 years, 2 months ago (2015-10-04 17:41:24 UTC) #9
jianjunz
On 2015/10/04 17:41:24, juberti wrote: > lgtm I don't have permission to run CQ. Could ...
5 years, 2 months ago (2015-10-05 00:15:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378353005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378353005/1
5 years, 2 months ago (2015-10-05 02:57:35 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-05 02:57:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378353005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378353005/1
5 years, 2 months ago (2015-10-05 02:58:27 UTC) #16
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-05 02:58:28 UTC) #18
guoweis_webrtc
Committed patchset #1 (id:1) manually as 42b4faa28afed9e9358c97aae85f0ef742afa196 (presubmit successful).
5 years, 2 months ago (2015-10-05 03:02:57 UTC) #19
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/42b4faa28afed9e9358c97aae85f0ef742afa196 Cr-Commit-Position: refs/heads/master@{#10159}
5 years, 2 months ago (2015-10-05 03:03:00 UTC) #20
jianjunz
5 years, 2 months ago (2015-10-05 03:24:20 UTC) #21
Message was sent while issue was closed.
On 2015/10/05 03:03:00, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/42b4faa28afed9e9358c97aae85f0ef742afa196
> Cr-Commit-Position: refs/heads/master@{#10159}

Thanks for committing this CL.

Powered by Google App Engine
This is Rietveld 408576698