Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issue 1377783002: Revert of Android VideoCapturer: Send ByteBuffer instead of byte[] (Closed)

Created:
5 years, 2 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Android VideoCapturer: Send ByteBuffer instead of byte[] (patchset #1 id:1 of https://codereview.webrtc.org/1372813002/ ) Reason for revert: The top row in the video stream from the camera is messed up. The byte[] pointer is not the same as GetDirectBufferAddress() apparently. Original issue's description: > Android VideoCapturer: Send ByteBuffer instead of byte[] > > The purpose with this CL is to replace GetByteArrayElements() and ReleaseByteArrayElements() with GetDirectBufferAddress(). > > R=hbos@webrtc.org > > Committed: https://crrev.com/cb3649b40b3fd6d5bbb0a92003b717e46ce90924 > Cr-Commit-Position: refs/heads/master@{#10091} TBR=hbos@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b5815c801362c98d99668924a8d3ba763ec36a04 Cr-Commit-Position: refs/heads/master@{#10103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -26 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 2 chunks +2 lines, -3 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 6 chunks +15 lines, -15 lines 0 comments Download
M talk/app/webrtc/java/jni/androidvideocapturer_jni.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/java/jni/androidvideocapturer_jni.cc View 2 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
magjed_webrtc
Created Revert of Android VideoCapturer: Send ByteBuffer instead of byte[]
5 years, 2 months ago (2015-09-29 08:13:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377783002/1
5 years, 2 months ago (2015-09-29 08:13:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 08:13:46 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 08:13:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5815c801362c98d99668924a8d3ba763ec36a04
Cr-Commit-Position: refs/heads/master@{#10103}

Powered by Google App Engine
This is Rietveld 408576698