Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 1376723002: Remove isolate_deps_dir from .gitignore (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove isolate_deps_dir from .gitignore It turns out that if a bot is interrupted during test execution, the existence of this directory causes the next build to fail. This usually happens when the Buildbot master is restarted. TBR=mflodman@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/38502a7be4ada36eb0db5ea3be0b7e2fd0d9ae42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/38502a7be4ada36eb0db5ea3be0b7e2fd0d9ae42 Cr-Commit-Position: refs/heads/master@{#10105}
5 years, 2 months ago (2015-09-29 10:34:57 UTC) #1
kjellander_webrtc
Committed patchset #1 (id:1) manually as 38502a7be4ada36eb0db5ea3be0b7e2fd0d9ae42 (presubmit successful).
5 years, 2 months ago (2015-09-29 10:34:58 UTC) #2
kjellander_webrtc
5 years, 2 months ago (2015-09-29 10:35:14 UTC) #3
Message was sent while issue was closed.
This should solve our currently red Android bots due to the recent master
restart. I have verified the dir is not ignored in Chromium's .gitignore.

Powered by Google App Engine
This is Rietveld 408576698