Align new VoE API with design.

Align new VoE API with design.

BUG=webrtc:4690
Committed: https://crrev.com/cf18b34cf3bbb1cc2984f8ae3a1c5cebf92b7007
Cr-Commit-Position: refs/heads/master@{#10136}

[the sun, 2015-09-30 08:45:44]

solenberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2015-09-30 12:04:30]

lgtm

https://codereview.webrtc.org/1376153003/diff/1/webrtc/audio_send_stream.h
File webrtc/audio_send_stream.h (right):

https://codereview.webrtc.org/1376153003/diff/1/webrtc/audio_send_stream.h#ne...
webrtc/audio_send_stream.h:53: // outside of Call.
It might not be immediately clear if "temporarily" means this is used only for
brief periods, or if it's a temporary construct. Maybe

  // Underlying VoiceEngine handle, used to map AudioSendStream
  // to lower-level components.
  // TODO(🌄1): Remove when VoiceEngine channels are no longer
  // created outside of Call.

[the sun, 2015-09-30 12:11:57]

On 2015/09/30 12:04:30, kwiberg-webrtc wrote:
> lgtm
> 
> https://codereview.webrtc.org/1376153003/diff/1/webrtc/audio_send_stream.h
> File webrtc/audio_send_stream.h (right):
> 
>
https://codereview.webrtc.org/1376153003/diff/1/webrtc/audio_send_stream.h#ne...
> webrtc/audio_send_stream.h:53: // outside of Call.
> It might not be immediately clear if "temporarily" means this is used only for
> brief periods, or if it's a temporary construct. Maybe
> 
>   // Underlying VoiceEngine handle, used to map AudioSendStream
>   // to lower-level components.
>   // TODO(🌄1): Remove when VoiceEngine channels are no longer
>   // created outside of Call.

Good suggestion, oh unicode master. :)

[the sun, 2015-09-30 12:12:21]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-09-30 12:12:22]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1376153003/#ps20001 (title:
"comments")

[commit-bot: I haz the power, 2015-09-30 12:12:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1376153003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1376153003/20001

[commit-bot: I haz the power, 2015-09-30 12:14:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 12:14:35]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1015)

[the sun, 2015-09-30 12:17:44]

solenberg@webrtc.org changed reviewers:
+ tina.legrand@webrtc.org

[tlegrand-webrtc, 2015-10-01 12:26:03]

lgtm

[the sun, 2015-10-01 12:27:58]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-10-01 12:27:58]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org,
tina.legrand@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1376153003/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2015-10-01 12:28:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1376153003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1376153003/40001

[commit-bot: I haz the power, 2015-10-01 14:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 14:28:24]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[the sun, 2015-10-01 15:11:40]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2015-10-01 15:11:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1376153003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1376153003/40001

[commit-bot: I haz the power, 2015-10-01 15:13:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-01 15:13:52]

Patchset 3 (id:??) landed as
https://crrev.com/cf18b34cf3bbb1cc2984f8ae3a1c5cebf92b7007
Cr-Commit-Position: refs/heads/master@{#10136}