Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1375543003: Reland "Change WebRTC SslCipher to be exposed as number only" (Closed)

Created:
5 years, 2 months ago by guoweis_webrtc
Modified:
5 years, 2 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland Change WebRTC SslCipher to be exposed as number only This is to revert the change of https://codereview.webrtc.org/1380603005/ TBR=pthatcher@webrtc.org BUG=523033 Committed: https://crrev.com/456696a9c1bbd586701dcca3e4b2695e419a10ba Cr-Commit-Position: refs/heads/master@{#10126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -279 lines) Patch
M talk/app/webrtc/fakemetricsobserver.h View 1 chunk +6 lines, -10 lines 0 comments Download
M talk/app/webrtc/fakemetricsobserver.cc View 2 chunks +11 lines, -26 lines 0 comments Download
M talk/app/webrtc/peerconnection_unittest.cc View 4 chunks +64 lines, -60 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 chunk +8 lines, -3 lines 0 comments Download
M talk/app/webrtc/statscollector.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M talk/app/webrtc/umametrics.h View 2 chunks +7 lines, -6 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 chunk +14 lines, -13 lines 0 comments Download
M talk/session/media/channel.h View 4 chunks +5 lines, -4 lines 0 comments Download
M talk/session/media/channel.cc View 5 chunks +9 lines, -6 lines 0 comments Download
M talk/session/media/channel_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M talk/session/media/mediasession.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/session/media/mediasession.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M talk/session/media/mediasession_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M talk/session/media/srtpfilter.h View 2 chunks +1 line, -7 lines 0 comments Download
M talk/session/media/srtpfilter.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M talk/session/media/srtpfilter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/opensslstreamadapter.h View 2 chunks +7 lines, -7 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 7 chunks +49 lines, -42 lines 0 comments Download
M webrtc/base/sslstreamadapter.h View 3 chunks +28 lines, -6 lines 0 comments Download
M webrtc/base/sslstreamadapter.cc View 4 chunks +26 lines, -7 lines 0 comments Download
M webrtc/base/sslstreamadapter_unittest.cc View 2 chunks +27 lines, -27 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375543003/1
5 years, 2 months ago (2015-10-01 04:38:01 UTC) #2
guoweis_webrtc
Committed patchset #1 (id:1) manually as 456696a9c1bbd586701dcca3e4b2695e419a10ba (presubmit successful).
5 years, 2 months ago (2015-10-01 04:49:14 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 04:49:16 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/456696a9c1bbd586701dcca3e4b2695e419a10ba
Cr-Commit-Position: refs/heads/master@{#10126}

Powered by Google App Engine
This is Rietveld 408576698